Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard/server] Fix "start-workspace-cycle" on image builder errors #4875

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 20, 2021

Fixes #4856.

I pushed bf44fa1 should serve as reproducer for #4856.

Test

  1. Go to https://gpl-4856-prebuild-cycle.staging.gitpod-dev.com/workspaces/
  2. Open dev console
  3. Start a prebuild suing /#prebuild/ which triggers a fresh image-build that takes longer than 1 minute
  4. Note how you see exactly one line of /start: started workspace instance: after ~1 minute
  5. Note how you get stuck on the prebuild page 😕 (cmp. Prebuild process gets stuck (when updating .gitpod.Dockerfile) #4856 (comment))

Under certain circumstances - if a workspace failure appeared before the ideURL got set - we would never leave the HeadlessLogView but start a new workspace over and over again. As we do not handle this error well, it would only get caught by timeouts (1h), leading to users being effectively blocked because they reached their parallel workspace limit
@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #4875 (bf44fa1) into main (f5793c3) will increase coverage by 34.44%.
The diff coverage is n/a.

❗ Current head bf44fa1 differs from pull request most recent head 3b89aac. Consider uploading reports for the commit 3b89aac to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4875       +/-   ##
=========================================
+ Coverage      0   34.44%   +34.44%     
=========================================
  Files         0        1        +1     
  Lines         0       90       +90     
=========================================
+ Hits          0       31       +31     
- Misses        0       55       +55     
- Partials      0        4        +4     
Flag Coverage Δ
components-image-builder-app 34.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/image-builder/pkg/resolve/resolve.go 34.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5793c3...3b89aac. Read the comment docs.

@geropl geropl marked this pull request as ready for review July 20, 2021 08:52
@geropl
Copy link
Member Author

geropl commented Jul 20, 2021

/assign @csweichel

@geropl geropl removed the request for review from JanKoehnlein July 20, 2021 09:24
@AlexTugarev
Copy link
Member

(With the current test setup, i.e. test commit) I get the deadline exceeded error as follows

Screen Shot 2021-07-20 at 11 32 54

@geropl
Copy link
Member Author

geropl commented Jul 20, 2021

(With the current test setup, i.e. test commit) I get the deadline exceeded error as follows

@AlexTugarev That looks good so far. Do you see the single line /start: started workspace instance: in the web console as mentioned here?

@AlexTugarev
Copy link
Member

Do you see the single line /start: started workspace instance: in the web console as mentioned here?

yes. that's true.

@geropl
Copy link
Member Author

geropl commented Jul 20, 2021

Do you see the single line /start: started workspace instance: in the web console as mentioned here?

yes. that's true.

Test succeeded ✔️

Will remove the test commit.

Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Code changes make sense.
Waited to for the re-deploy to verify it's not breaking things.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d6a5ccd70d98e5fd76004a1b140ad785dcf89a58

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 03459a1 into main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prebuild process gets stuck (when updating .gitpod.Dockerfile)
4 participants