-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard/server] Fix "start-workspace-cycle" on image builder errors #4875
Conversation
Under certain circumstances - if a workspace failure appeared before the ideURL got set - we would never leave the HeadlessLogView but start a new workspace over and over again. As we do not handle this error well, it would only get caught by timeouts (1h), leading to users being effectively blocked because they reached their parallel workspace limit
Codecov Report
@@ Coverage Diff @@
## main #4875 +/- ##
=========================================
+ Coverage 0 34.44% +34.44%
=========================================
Files 0 1 +1
Lines 0 90 +90
=========================================
+ Hits 0 31 +31
- Misses 0 55 +55
- Partials 0 4 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/assign @csweichel |
@AlexTugarev That looks good so far. Do you see the single line |
yes. that's true. |
Test succeeded ✔️ Will remove the test commit. |
bf44fa1
to
3b89aac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Code changes make sense.
Waited to for the re-deploy to verify it's not breaking things.
LGTM label has been added. Git tree hash: d6a5ccd70d98e5fd76004a1b140ad785dcf89a58
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev, geropl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #4856.
I pushed bf44fa1 should serve as reproducer for #4856.
Test
/#prebuild/
which triggers a fresh image-build that takes longer than 1 minute/start: started workspace instance:
after ~1 minute.gitpod.Dockerfile
) #4856 (comment))