Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manmager] Remove span logs from WorkspaceReadyProbe #4883

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 20, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Jul 20, 2021

/assign @csweichel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Jul 20, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 11cffb5f23fdbc9726a676dbcd3c592e5d6ce09d

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #4883 (e062d28) into main (03459a1) will increase coverage by 36.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4883       +/-   ##
=========================================
+ Coverage      0   36.81%   +36.81%     
=========================================
  Files         0       13       +13     
  Lines         0     3667     +3667     
=========================================
+ Hits          0     1350     +1350     
- Misses        0     2201     +2201     
- Partials      0      116      +116     
Flag Coverage Δ
components-ws-manager-app 36.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/probe.go 0.00% <ø> (ø)
...-manager/pkg/manager/internal/workpool/workpool.go 100.00% <0.00%> (ø)
components/ws-manager/pkg/manager/config.go 32.50% <0.00%> (ø)
components/ws-manager/pkg/manager/imagespec.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 26.05% <0.00%> (ø)
components/ws-manager/pkg/manager/monitor.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 79.05% <0.00%> (ø)
...omponents/ws-manager/pkg/manager/pod_controller.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/metrics.go 11.26% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go 74.46% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03459a1...e062d28. Read the comment docs.

@roboquat roboquat merged commit cad4fbf into main Jul 20, 2021
@roboquat roboquat deleted the aledbf/spanlog branch July 20, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants