Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[content-service] Start snapshots from-other #4905

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 22, 2021

to make the tasks behave like a workspace restart.

This change makes snapshots behave as documented.

fixes #4894

How to test

  1. Open https://csweichel-init-command-beeing-run-4894.staging.gitpod-dev.com#snapshot/3c239bd3-d3ff-4399-9ffe-e419ac99858a
  2. cat /workspace/.gitpod/ready should be from-backup

to make the tasks behave like a workspace restart
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #4905 (4964b53) into main (08a23d9) will increase coverage by 32.69%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4905       +/-   ##
=========================================
+ Coverage      0   32.69%   +32.69%     
=========================================
  Files         0       69       +69     
  Lines         0    13735    +13735     
=========================================
+ Hits          0     4491     +4491     
- Misses        0     8828     +8828     
- Partials      0      416      +416     
Flag Coverage Δ
components-content-service-app 14.46% <0.00%> (?)
components-content-service-lib 14.46% <0.00%> (?)
components-image-builder-app 34.44% <ø> (?)
components-supervisor-app 36.23% <ø> (?)
components-ws-daemon-app 22.29% <ø> (?)
components-ws-manager-app 36.81% <ø> (?)
components-ws-proxy-app 67.06% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onents/content-service/pkg/initializer/snapshot.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/workspacerouter.go 81.73% <0.00%> (ø)
components/ws-daemon/pkg/quota/sandbox_linux.go 0.00% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 60.38% <0.00%> (ø)
components/ws-daemon/pkg/quota/mounts.go 53.19% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/content-service/pkg/storage/minio.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go 66.66% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 70.84% <0.00%> (ø)
...nts/content-service/pkg/service/content-service.go 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08a23d9...4964b53. Read the comment docs.

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nicely :-)

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87d67a272a869db8b6b53de0f2be88c33dd68fad

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, svenefftinge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0db062b into main Jul 22, 2021
@roboquat roboquat deleted the csweichel/init-command-beeing-run-4894 branch July 22, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init command beeing run when opening snapshot
3 participants