-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspacekit] Discover bind mount paths #4912
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4912 +/- ##
=======================================
+ Coverage 0 7.69% +7.69%
=======================================
Files 0 3 +3
Lines 0 585 +585
=======================================
+ Hits 0 45 +45
- Misses 0 537 +537
- Partials 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a6bfb01
to
dfee07e
Compare
dfee07e
to
0f03e89
Compare
/lgtm |
LGTM label has been added. Git tree hash: 5b2de83584608677f358a3c643e5e66fc8c2ba81
|
0f03e89
to
21b38cd
Compare
/lgtm |
LGTM label has been added. Git tree hash: 45642c44a5e2f68995091f1239bdcf43d7f75521
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Prior to this PR the paths we'd bind mount into ring1 were hardcoded in workspacekit. This PR makes workspacekit "auto-discover" such paths using a "configMap/secret heuristic" (see here).
In addition, bind mount paths can be explicitly specified using the
GITPOD_WORKSPACEKIT_BIND_MOUNTS
environment variable, which expects a JSON array of paths.