Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Discover bind mount paths #4912

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 22, 2021

Prior to this PR the paths we'd bind mount into ring1 were hardcoded in workspacekit. This PR makes workspacekit "auto-discover" such paths using a "configMap/secret heuristic" (see here).

In addition, bind mount paths can be explicitly specified using the GITPOD_WORKSPACEKIT_BIND_MOUNTS environment variable, which expects a JSON array of paths.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #4912 (21b38cd) into main (d12cd34) will increase coverage by 7.69%.
The diff coverage is 52.63%.

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #4912      +/-   ##
=======================================
+ Coverage      0   7.69%   +7.69%     
=======================================
  Files         0       3       +3     
  Lines         0     585     +585     
=======================================
+ Hits          0      45      +45     
- Misses        0     537     +537     
- Partials      0       3       +3     
Flag Coverage Δ
components-workspacekit-app 7.69% <52.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 7.58% <52.63%> (ø)
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12cd34...21b38cd. Read the comment docs.

@csweichel csweichel force-pushed the cw/rings-discover-paths branch 2 times, most recently from a6bfb01 to dfee07e Compare July 22, 2021 15:38
@csweichel csweichel requested review from aledbf and removed request for rl-gitpod July 22, 2021 15:47
@aledbf
Copy link
Member

aledbf commented Jul 22, 2021

/lgtm
/approve

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b2de83584608677f358a3c643e5e66fc8c2ba81

@roboquat roboquat removed the lgtm label Jul 22, 2021
@csweichel csweichel marked this pull request as ready for review July 22, 2021 18:31
@aledbf
Copy link
Member

aledbf commented Jul 22, 2021

/lgtm

@roboquat roboquat added the lgtm label Jul 22, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45642c44a5e2f68995091f1239bdcf43d7f75521

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csweichel
Copy link
Contributor Author

/meow

@roboquat
Copy link
Contributor

@csweichel: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roboquat roboquat merged commit 4c5bce0 into main Jul 22, 2021
@roboquat roboquat deleted the cw/rings-discover-paths branch July 22, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants