Revise Prebuilds Page #4970

AlexTugarev · 2021-07-27T13:30:04Z

Addressing issues from #4958

gtsiolis · 2021-07-27T14:49:33Z

Looking at this now! 👀

gtsiolis

Thanks for picking this up @AlexTugarev! Left some comments below. 🏀

Added a follow up issue in #4972 about project search as it seems to be out of the scope of this PR. For some reason, I could not see any prebuilds entries or open a prebuild page. 😭

components/dashboard/src/projects/Prebuilds.tsx

components/dashboard/src/projects/Project.tsx

components/dashboard/src/projects/render-utils.tsx

components/dashboard/src/projects/Project.tsx

components/dashboard/src/projects/Prebuilds.tsx

gtsiolis

Thanks for fixing the deployment, @AlexTugarev! Added a few more comments below! 🍍

components/dashboard/src/Menu.tsx

components/dashboard/src/projects/Prebuilds.tsx

components/dashboard/src/projects/Project.tsx

components/dashboard/src/App.tsx

roboquat · 2021-07-28T14:29:44Z

@gtsiolis:

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

components/dashboard/src/projects/Project.tsx

jankeromnes · 2021-07-29T13:28:43Z

components/dashboard/src/projects/Project.tsx

+                    if (!filter(branch)) {
+                        return undefined;
+                    }


Nit: Wouldn't it be cleaner to filter out branches before the .map? E.g. like so:

{branches.filter(filter).map((branch, index) => { // ...

sounds good! will apply in the following PR.

components/server/src/github/github-repository-provider.ts

jankeromnes · 2021-07-29T14:47:44Z

components/server/src/projects/projects-service.ts

@@ -71,7 +78,8 @@ export class ProjectsService {
                changeUrl: "changeUrl", // todo: compute in repositoryProvider
            });
        }
-        return result;
+        result.sort((a, b) => (b.changeDate || "").localeCompare(a.changeDate || ""));
+        return result.slice(0, 30);


Question: Out of curiosity, why limit this to 30 in the backend, as opposed to in the front-end?

Good point!

components/gitpod-protocol/src/protocol.ts

jankeromnes · 2021-07-30T08:14:46Z

components/server/ee/src/workspace/gitpod-server-impl.ts

@@ -1461,7 +1461,7 @@ export class GitpodServerEEImpl extends GitpodServerImpl<GitpodClient, GitpodSer
        return repositories;
    }

-    async triggerPrebuild(projectId: string, branch: string): Promise<void> {
+    async triggerPrebuild(projectId: string, branchName: string): Promise<void> {


Nit: I understand that public is the default, but maybe not every developer that ever looks at this code will know that. Also, I think it's slightly dangerous to be inconsistent in this file (e.g. if you see both public async and async, you might accidentally think the second is private by default).

Please either respect the file-local convention (i.e. explicit public keyword), or refactor the entire file in a separate commit (i.e. remove all the public prefixes).

jankeromnes · 2021-07-30T08:16:02Z

components/server/src/bitbucket/bitbucket-repository-provider.ts

@@ -26,6 +26,11 @@ export class BitbucketRepositoryProvider implements RepositoryProvider {
        return { host, owner, name, cloneUrl, description, avatarUrl, webUrl };
    }

+    async getBranch(user: User, owner: string, repo: string, branch: string): Promise<Branch> {
+        // todo
+        throw new Error("not implemented");


Q: When will we implement the Bitbucket and GitLab methods?

Planing to implement GitLab support tomorrow.

No plans for BitBucket so far. TODO: remove from selection list for the time being.

jankeromnes

Modulo the few nits / questions / suggestions, this change looks good to me and can be merged! Many thanks!

/lgtm

/hold

roboquat · 2021-07-30T08:19:16Z

LGTM label has been added.

Git tree hash: c1c1d71d4c1f0bb36a030dbb29a3fdb143537cdb

roboquat · 2021-07-30T08:19:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, jankeromnes

Associated issue: #4958

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~components/dashboard/OWNERS~~ [AlexTugarev,jankeromnes]
~~components/gitpod-protocol/OWNERS~~ [AlexTugarev,jankeromnes]
~~components/server/OWNERS~~ [AlexTugarev,jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

using a couple of graphql queries instead of many rest requests. ordering by change date. limiting to 30 items.

roboquat · 2021-08-02T07:17:57Z

New changes are detected. LGTM label has been removed.

jankeromnes · 2021-08-02T07:48:08Z

Still /lgtm 😁 many thanks!

AlexTugarev · 2021-08-02T07:49:37Z

/unhold

AlexTugarev added 5 commits July 27, 2021 06:40

[projects] remove settings page

c42eb8e

[projects] fixes truncate commit message

b90fa62

[projects] fix short hash rendering

7c160f9

[projects] remove status filter

4a5751c

[projects] remove "cancel prebuild" item

7fe5cdc

AlexTugarev requested a review from gtsiolis July 27, 2021 13:30

roboquat added the approved label Jul 27, 2021

roboquat requested review from jankeromnes, JanKoehnlein and svenefftinge July 27, 2021 13:30

AlexTugarev removed the request for review from JanKoehnlein July 27, 2021 13:30

roboquat added the size/L label Jul 27, 2021

gtsiolis linked an issue Jul 27, 2021 that may be closed by this pull request

Follow up issues for the prebuilds pages #4958

Closed

17 tasks

gtsiolis reviewed Jul 27, 2021

View reviewed changes

AlexTugarev force-pushed the at/prebuild-page branch from b0443bd to 4e556b8 Compare July 28, 2021 07:33

gtsiolis reviewed Jul 28, 2021

View reviewed changes

gtsiolis linked an issue Jul 28, 2021 that may be closed by this pull request

Allow users to delete a project #4704

Closed

gtsiolis mentioned this pull request Jul 28, 2021

Add linked pull requests for prebuilds and branches in the commit column #4983

Open

AlexTugarev force-pushed the at/prebuild-page branch from 4e556b8 to 70d5874 Compare July 28, 2021 14:00

AlexTugarev force-pushed the at/prebuild-page branch from 70d5874 to 1f066dc Compare July 28, 2021 15:58

gtsiolis added component: dashboard 🧑‍🚀 crew: teams and projects labels Jul 28, 2021

jankeromnes reviewed Jul 29, 2021

View reviewed changes

components/dashboard/src/projects/Project.tsx Outdated Show resolved Hide resolved

jankeromnes reviewed Jul 29, 2021

View reviewed changes

gtsiolis mentioned this pull request Jul 29, 2021

Rename the prebuild trigger action #5008

Open

jankeromnes reviewed Jul 29, 2021

View reviewed changes

components/server/src/github/github-repository-provider.ts Show resolved Hide resolved

jankeromnes reviewed Jul 29, 2021

View reviewed changes

jankeromnes reviewed Jul 30, 2021

View reviewed changes

components/gitpod-protocol/src/protocol.ts Show resolved Hide resolved

jankeromnes reviewed Jul 30, 2021

View reviewed changes

jankeromnes approved these changes Jul 30, 2021

View reviewed changes

roboquat added the do-not-merge/hold label Jul 30, 2021

roboquat assigned jankeromnes Jul 30, 2021

roboquat added the lgtm label Jul 30, 2021

AlexTugarev added 7 commits August 2, 2021 07:17

[projects] rename overview page

130ed5c

[project] add menu spacing

c8c7b92

[projects] add contextURL for branches

40af349

[projects] fix search on overview page

7a18a52

[projects] add default badge

1eecdd3

[prebuilds] speed up query for active branches

1f24982

using a couple of graphql queries instead of many rest requests. ordering by change date. limiting to 30 items.

[projects] increase repo listing limit

88b36e9

AlexTugarev force-pushed the at/prebuild-page branch from 1f066dc to 88b36e9 Compare August 2, 2021 07:17

roboquat removed the lgtm label Aug 2, 2021

jankeromnes added the lgtm label Aug 2, 2021

roboquat removed the do-not-merge/hold label Aug 2, 2021

roboquat merged commit 97006a8 into main Aug 2, 2021

roboquat deleted the at/prebuild-page branch August 2, 2021 07:50

This was referenced Aug 2, 2021

Add confirmation modal when deleting projects #5034

Closed

Add triggerrer avatar information in prebuilds #5035

Open

Optimize SVG files used for icons #5036

Open

Improve performance for fetching active branches and prebuilds #5038

Open

gtsiolis mentioned this pull request Sep 7, 2021

Change default branch label colors for dark theme #5556

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revise Prebuilds Page #4970

Revise Prebuilds Page #4970

AlexTugarev commented Jul 27, 2021

gtsiolis commented Jul 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

gtsiolis left a comment

gtsiolis left a comment

roboquat commented Jul 28, 2021

jankeromnes Jul 29, 2021 •

edited

Loading

AlexTugarev Aug 2, 2021

jankeromnes Jul 29, 2021

AlexTugarev Aug 2, 2021

jankeromnes Jul 30, 2021

jankeromnes Jul 30, 2021

AlexTugarev Aug 2, 2021

jankeromnes left a comment

roboquat commented Jul 30, 2021

roboquat commented Jul 30, 2021

roboquat commented Aug 2, 2021

jankeromnes commented Aug 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading

AlexTugarev commented Aug 2, 2021

Revise Prebuilds Page #4970

Revise Prebuilds Page #4970

Conversation

AlexTugarev commented Jul 27, 2021

gtsiolis commented Jul 27, 2021 • edited by werft-gitpod-dev-com bot Loading

gtsiolis left a comment

Choose a reason for hiding this comment

gtsiolis left a comment

Choose a reason for hiding this comment

roboquat commented Jul 28, 2021

jankeromnes Jul 29, 2021 • edited Loading

Choose a reason for hiding this comment

AlexTugarev Aug 2, 2021

Choose a reason for hiding this comment

jankeromnes Jul 29, 2021

Choose a reason for hiding this comment

AlexTugarev Aug 2, 2021

Choose a reason for hiding this comment

jankeromnes Jul 30, 2021

Choose a reason for hiding this comment

jankeromnes Jul 30, 2021

Choose a reason for hiding this comment

AlexTugarev Aug 2, 2021

Choose a reason for hiding this comment

jankeromnes left a comment

Choose a reason for hiding this comment

roboquat commented Jul 30, 2021

roboquat commented Jul 30, 2021

roboquat commented Aug 2, 2021

jankeromnes commented Aug 2, 2021 • edited by werft-gitpod-dev-com bot Loading

AlexTugarev commented Aug 2, 2021

gtsiolis commented Jul 27, 2021 •

edited by werft-gitpod-dev-com bot

Loading

jankeromnes Jul 29, 2021 •

edited

Loading

jankeromnes commented Aug 2, 2021 •

edited by werft-gitpod-dev-com bot

Loading