Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(.github): security policy item gets automatically created when SECURITY.md exists #4980

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

leodido
Copy link
Contributor

@leodido leodido commented Jul 28, 2021

Since the repository already contains a SECURITY.md file there's no need to specify a link to an external page (which is referred to by the SECURITY.md file).

The issue menu will automatically show an item like the following one.

image

Clicking on it will bring the user to this GitHub page (Security tab > Security policy):

image

Putting this in

/hold

because I first wanna discuss it with the team internally.

Fixes #4979

@roboquat roboquat requested a review from aledbf July 28, 2021 07:25
@leodido leodido changed the title fix(.github): security policy gets automatically created when SECURITY.md exists fix(.github): security policy item gets automatically created when SECURITY.md exists Jul 28, 2021
@csweichel
Copy link
Contributor

/LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 214b347d7c72319b27960cc87f3ac683964a54bf

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, leodido

Associated issue: #4979

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leodido
Copy link
Contributor Author

leodido commented Jul 28, 2021

/hold cancel

@roboquat roboquat merged commit 5e9834b into main Jul 28, 2021
@roboquat roboquat deleted the leo/fix-issue-config branch July 28, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double entry in the issue menu
3 participants