Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart] Remove deprecated field 'maxBackupSize' from _helpers.tpl #4987

Merged
merged 1 commit into from
Jul 28, 2021
Merged

[chart] Remove deprecated field 'maxBackupSize' from _helpers.tpl #4987

merged 1 commit into from
Jul 28, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Jul 28, 2021 •
edited
Loading

Fixes ws-daemon crash loop back-off in dev staging:

    "error": "json: unknown field \"maxBackupSize\""

Follow-up to #4969

@jankeromnes
[chart] Remove deprecated field 'maxBackupSize' from _helpers.tpl
ad9ea0e 
Fixes ws-daemon CrashLoopBackoff:

    "error": "json: unknown field \"maxBackupSize\""
@jankeromnes jankeromnes requested a review from geropl July 28, 2021 12:42
@roboquat roboquat requested a review from rl-gitpod July 28, 2021 12:42
@jankeromnes jankeromnes removed the request for review from rl-gitpod July 28, 2021 12:43
geropl
geropl approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roboquat roboquat added the lgtm label Jul 28, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc61bf0f2a9f08bd5434a35cab1208eed6246360

@geropl
Copy link
Member

geropl commented Jul 28, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, jankeromnes

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes
Copy link
Contributor Author

Seems to indeed fix the dev-staging ws-daemon crash loop back-off:

ws-daemon-56qxl                              2/2     Running       0          37s
ws-daemon-62srs                              2/2     Running       0          38s
ws-daemon-knlcm                              2/2     Running       0          37s
ws-daemon-tf286                              1/2     Running       0          36s
ws-manager-88db86cc6-7c9pr                   2/2     Running       0          37s

@roboquat roboquat merged commit 7892961 into main Jul 28, 2021
@roboquat roboquat deleted the jx/remove-maxBackupSize branch July 28, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees

@geropl geropl

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jankeromnes @roboquat @geropl