Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Remove old sandboxing behaviour #4994

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 28, 2021

fixes #4993

We used to have some means to limit the size of a workspace by placing its content in a loopback-mounted file. This mechanism never worked well and we haven't enabled it in about a year's time. Now, with recent harmonisation on the config surface (#4969) we inadvertently re-enabled this old behaviour.

This PR does away with this broken "sandbox" mechanism.

@csweichel csweichel force-pushed the csweichel/ws-manager-remove-old-4993 branch from dc8b7c0 to 0f19525 Compare July 28, 2021 16:21
@roboquat roboquat added size/XL and removed size/L labels Jul 28, 2021
@csweichel csweichel requested review from aledbf and removed request for rl-gitpod July 28, 2021 16:22
@aledbf
Copy link
Member

aledbf commented Jul 28, 2021

/lgtm

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue: #4993

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55c2db6b078e74437d8a02bf15f1bc1ce4af4879

@aledbf
Copy link
Member

aledbf commented Jul 28, 2021

delete-all-the-things

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #4994 (0f19525) into main (5b15f69) will increase coverage by 22.99%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4994       +/-   ##
=========================================
+ Coverage      0   22.99%   +22.99%     
=========================================
  Files         0       11       +11     
  Lines         0     1918     +1918     
=========================================
+ Hits          0      441      +441     
- Misses        0     1418     +1418     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 22.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/content/service.go 0.00% <ø> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 45.63% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b15f69...0f19525. Read the comment docs.

@roboquat roboquat merged commit 06c27e9 into main Jul 28, 2021
@roboquat roboquat deleted the csweichel/ws-manager-remove-old-4993 branch July 28, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-manager] Remove old workspaceSizeLimit behaviour
3 participants