Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder] Update go dependencies (mk3) #4998

Merged
merged 4 commits into from
Aug 1, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 28, 2021

Align dependencies with the rest of the projext:

  • github.com/docker/docker v20.10.7+incompatible
  • github.com/containerd/containerd v1.5.4

The update of the docker dependency also improves the error stack trace.

@aledbf
Copy link
Member Author

aledbf commented Jul 28, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #4998 (a20de10) into main (698a17b) will decrease coverage by 16.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #4998       +/-   ##
==========================================
- Coverage   23.02%   6.96%   -16.06%     
==========================================
  Files          11       6        -5     
  Lines        1915    1564      -351     
==========================================
- Hits          441     109      -332     
- Misses       1415    1448       +33     
+ Partials       59       7       -52     
Flag Coverage Δ
components-image-builder-mk3-app 6.53% <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-workspacekit-app 7.69% <ø> (?)
components-ws-daemon-app ?
dev-loadgen-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/image-builder-mk3/pkg/orchestrator/monitor.go 11.80% <ø> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go 0.00% <ø> (ø)
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/resources/dispatch.go
components/ws-daemon/pkg/content/tar.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/resources/controller.go
components/ws-daemon/pkg/resources/limiter.go
components/ws-daemon/pkg/content/config.go
components/ws-daemon/pkg/content/service.go
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698a17b...a20de10. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 1, 2021
@roboquat
Copy link
Contributor

roboquat commented Aug 1, 2021

LGTM label has been added.

Git tree hash: 638843df808ac752fdd46d02670ae70d71157ef5

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Aug 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 1665910 into main Aug 1, 2021
@roboquat roboquat deleted the aledbf/mk3update branch August 1, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants