[supervisor] Reword upload message #5051
Conversation
|
no objections, but is there an issue for it? not sure what is a trigger for the fix |
Codecov Report
@@ Coverage Diff @@
## main #5051 +/- ##
=========================================
+ Coverage 0 37.21% +37.21%
=========================================
Files 0 15 +15
Lines 0 3853 +3853
=========================================
+ Hits 0 1434 +1434
- Misses 0 2301 +2301
- Partials 0 118 +118
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@akosyakov good point. In self-hosted, the message confuses users with prebuild images (even when this is just a plain build) |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 5bb2a8bbb3d61716ef7b785c3c68076396334d08
|
|
/approve no-issue but see #5051 (comment) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov Associated issue requirement bypassed by: akosyakov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -506,7 +506,7 @@ func (r *loggingHeadlessTaskProgressReporter) write(data string, task *task, ter | |||
|
|
|||
| func (r *loggingHeadlessTaskProgressReporter) done(success bool) { | |||
| workspaceLog := log.WithField("component", "workspace") | |||
| workspaceLog.WithField("taskLogMsg", taskLogMessage{Type: "workspaceTaskOutput", Data: "🚛 uploading prebuilt workspace"}).Info() | |||
| workspaceLog.WithField("taskLogMsg", taskLogMessage{Type: "workspaceTaskOutput", Data: "🚛 uploading workspace image"}).Info() | |||
There was a problem hiding this comment.
actually neither of those two messages is correct. In case of prebuilds the new message is wrong, incase of image builds the old one is.
There was a problem hiding this comment.
@csweichel why the old message is correct for normal builds?
No description provided.