Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] fix handling of incomplete referrer #5052

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

laushinka
Copy link
Contributor

Fixes #4701

I investigated the issue and found that it is not possible to retrieve the referrer information from Safari, even though the information is available in the request header.
Therefore what I did instead was fix the handling in FromReferrer.tsx, by showing the intended text when we don't have a complete referrer URL.
I also adjusted the text a little bit - please let me know if the new text is acceptable.

@JanKoehnlein
Copy link
Contributor

Thank you, this looks good codewise. Is it possible to test this (manually) and if so, could you provide the steps?

@JanKoehnlein
Copy link
Contributor

/cc @JanKoehnlein

@laushinka
Copy link
Contributor Author

Thank you, this looks good codewise. Is it possible to test this (manually) and if so, could you provide the steps?

Yes. These are the steps:

  1. Have the staging URL ready.
  2. On Safari, go to https://github.com/gitpod-io/gitpod.
  3. Inspect the "ready-to-code" href element, which should be "https://gitpod.io/from-referrer/".
  4. Change "https://gitpod.io" to the staging URL. It should then look something like "https://some-url.staging.gitpod-dev.com/from-referrer/"
  5. Click on the "ready-to-code" button and see it happen.

Screenshot 2021-08-04 at 14 34 33

Screenshot 2021-08-04 at 14 38 19

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

LGTM label has been added.

Git tree hash: 80bebeab998f47168956f0c692ac2245452de218

@roboquat
Copy link
Contributor

roboquat commented Aug 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #4701

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 899dd4b into main Aug 4, 2021
@roboquat roboquat deleted the laushinka/something-goes-wrong-4701 branch August 4, 2021 12:45
@JanKoehnlein
Copy link
Contributor

Congrats, @laushinka: Your first PR has been merged to Gitpod main!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something goes wrong when clicking on the Gitpod button from Safari
3 participants