Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Add more details when is not possible to update CPU limits #5082

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 5, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Aug 5, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #5082 (795fb45) into main (90f3a7f) will increase coverage by 23.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5082       +/-   ##
=========================================
+ Coverage      0   23.00%   +23.00%     
=========================================
  Files         0       11       +11     
  Lines         0     1917     +1917     
=========================================
+ Hits          0      441      +441     
- Misses        0     1417     +1417     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 23.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/resources/controller.go 33.69% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f3a7f...795fb45. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 6, 2021
@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

LGTM label has been added.

Git tree hash: 02f70e9a2e7e727686c4b1d83b8dfc0cdca04b35

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit dafeee8 into main Aug 6, 2021
@roboquat roboquat deleted the aledbf/limits branch August 6, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants