Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align invite members button on the team page #5093

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Align invite members button on the team page #5093

merged 1 commit into from
Aug 6, 2021

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Aug 6, 2021

Fix #5092.

BEFORE AFTER
button-before button-after

@roboquat roboquat requested a review from csweichel August 6, 2021 12:13
@gtsiolis gtsiolis removed the request for review from csweichel August 6, 2021 12:14
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 6, 2021 •
edited by werft-gitpod-dev-com bot
Loading

@svenefftinge could you take a look at this one-line change since you were involved in #4868? 🏀

@jankeromnes
Copy link
Contributor

jankeromnes commented Aug 6, 2021 •
edited by werft-gitpod-dev-com bot
Loading

I've added a Team & a Project to test this 😁 if you want to join that team: https://gt-align-invite-members-button.staging.gitpod-dev.com/teams/join?inviteId=ecb8c1b3-00ec-494b-b64f-dd5db4a1f0b0

jankeromnes
jankeromnes approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOES. THE. JOB. 🚀 🚀 🚀

/approve

@roboquat roboquat added the lgtm label Aug 6, 2021
@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

LGTM label has been added.

Git tree hash: 74766f5da2187916ff925054d6b4b34b04840c9a

@roboquat
Copy link
Contributor

roboquat commented Aug 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #5092

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a508322 into main Aug 6, 2021
@roboquat roboquat deleted the gt/align-invite-members-button branch August 6, 2021 13:14
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 6, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Thanks @jankeromnes! 🧑‍🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees

@jankeromnes jankeromnes

Labels
approved component: dashboard size/XS type: bug Something isn't working user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align invite member button on the team page
3 participants
@gtsiolis @jankeromnes @roboquat