-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[supervisor] Correctly reap child processes #5100
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5100 +/- ##
=========================================
+ Coverage 0 36.10% +36.10%
=========================================
Files 0 16 +16
Lines 0 4080 +4080
=========================================
+ Hits 0 1473 +1473
- Misses 0 2483 +2483
- Partials 0 124 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/werft run 👍 started the job as gitpod-build-cw-reaper.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I cannot see defunct processes anymore.
LGTM label has been added. Git tree hash: 82710b2682835f134a3d886f0a52ccbe88bee696
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov Associated issue: #5091 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #5091
by reaping all child processes, respecting
wait
interruptions and not blocking theSIGCHILD
handler.