Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update projects empty state #5112

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Update projects empty state #5112

merged 2 commits into from
Aug 11, 2021

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Aug 9, 2021

What does this PR do?

  1. Fix the help link (Learn more) on the Projects empty state.
  2. Refactor help links to use a single class named .gp-link as potentially a good name for a link component.

@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 9, 2021

@jankeromnes could you take a look at this small change since you initially added the learn-more class in 2588d5f? 🏀

@svenefftinge
Copy link
Member

svenefftinge commented Aug 11, 2021

/werft run

👍 started the job as gitpod-build-gt-update-projects-empty-state.1

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8339ea7c92f6e8c7e397194f03c926cde97e90cf

@svenefftinge
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svenefftinge

Associated issue requirement bypassed by: svenefftinge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3006c3e into main Aug 11, 2021
@roboquat roboquat deleted the gt/update-projects-empty-state branch August 11, 2021 12:54
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Aug 11, 2021

Je vous remercie, @svenefftinge! 🥐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants