Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Collect logs from runc command #5117

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Aug 9, 2021

fixes #4802

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #5117 (f157171) into main (5e232e8) will increase coverage by 32.24%.
The diff coverage is 0.00%.

❗ Current head f157171 differs from pull request most recent head 43ccbb1. Consider uploading reports for the commit 43ccbb1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5117       +/-   ##
=========================================
+ Coverage      0   32.24%   +32.24%     
=========================================
  Files         0      105      +105     
  Lines         0    20394    +20394     
=========================================
+ Hits          0     6576     +6576     
- Misses        0    13236    +13236     
- Partials      0      582      +582     
Flag Coverage Δ
components-blobserve-app 28.92% <ø> (?)
components-common-go-lib 30.71% <0.00%> (?)
components-content-service-api-go-lib ∅ <ø> (?)
components-content-service-app 14.47% <ø> (?)
components-content-service-lib 14.47% <ø> (?)
components-ee-agent-smith-app 26.12% <ø> (?)
components-ee-kedge-app 45.48% <ø> (?)
components-ee-ws-scheduler-app 62.68% <ø> (?)
components-image-builder-api-go-lib ∅ <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-bob-app ∅ <ø> (?)
components-image-builder-mk3-app 6.72% <ø> (?)
components-registry-facade-app 11.57% <ø> (?)
components-registry-facade-lib 11.57% <ø> (?)
components-service-waiter-app ∅ <ø> (?)
components-supervisor-app 37.48% <ø> (?)
components-workspacekit-app 7.65% <ø> (?)
components-ws-daemon-api-go-lib ∅ <ø> (?)
components-ws-daemon-app 22.95% <0.00%> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)
components-ws-manager-api-go-lib ∅ <ø> (?)
components-ws-manager-app 36.32% <ø> (?)
components-ws-proxy-app 66.98% <ø> (?)
dev-loadgen-app ∅ <ø> (?)
dev-poolkeeper-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/common-go/log/log.go 8.33% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-manager/pkg/manager/status.go 71.96% <0.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go 0.00% <0.00%> (ø)
components/blobserve/pkg/blobserve/blobspace.go 9.39% <0.00%> (ø)
...onents/content-service/pkg/initializer/prebuild.go 0.00% <0.00%> (ø)
...onents/content-service/pkg/service/blob-service.go 0.00% <0.00%> (ø)
components/content-service/pkg/layer/provider.go 36.76% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e232e8...43ccbb1. Read the comment docs.

@csweichel
Copy link
Contributor

csweichel commented Aug 10, 2021

/werft run

👍 started the job as gitpod-build-sje-add-logging-to-prebuild-init.1

@mrsimonemms mrsimonemms force-pushed the sje/add-logging-to-prebuild-init branch from 76164b6 to cb54263 Compare August 11, 2021 09:41
@csweichel
Copy link
Contributor

csweichel commented Aug 11, 2021

/werft run

👍 started the job as gitpod-build-sje-add-logging-to-prebuild-init.3

@mrsimonemms mrsimonemms force-pushed the sje/add-logging-to-prebuild-init branch from f157171 to 363438f Compare August 11, 2021 14:19
@mrsimonemms mrsimonemms force-pushed the sje/add-logging-to-prebuild-init branch from 363438f to 43ccbb1 Compare August 11, 2021 14:23
@mrsimonemms mrsimonemms marked this pull request as ready for review August 11, 2021 14:23
@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 19f4dc98525ab711833fae3be800e5b0cbcc26e5

@csweichel
Copy link
Contributor

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #4802

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 76a1e7b into main Aug 11, 2021
@roboquat roboquat deleted the sje/add-logging-to-prebuild-init branch August 11, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ws-daemon] missconfigured logging
3 participants