Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 7826291 #5136

Merged
merged 1 commit into from
Aug 10, 2021
Merged

revert 7826291 #5136

merged 1 commit into from
Aug 10, 2021

Conversation

fullmetalrooster
Copy link
Contributor

@fullmetalrooster fullmetalrooster commented Aug 10, 2021

There is a parsing error in templates/server-deployment.yaml:167.

ArgoCD complains:

rpc error: code = Unknown desc = Manifest generation error (cached): `/bin/sh -c helm template --release-name gitpod . ${values_files_arguments}` failed exit status 1: walk.go:74: found symbolic link in path: /tmp/git@github.com_gitpod-com_gitpod/charts/gitpod_io/charts/gitpod resolves to /tmp/git@github.com_gitpod-com_gitpod/gitpod-core/chart Error: parse error at (gitpod_io/charts/gitpod/templates/server-deployment.yaml:167): unclosed action Use --debug flag to render out invalid YAML

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 709b0b061c0f7c2bc62695b942463121efab6406

@JanKoehnlein
Copy link
Contributor

I will try to fix the original commit tomorrow. Until then:

/lgtm

@JanKoehnlein
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein, princerachit

Associated issue requirement bypassed by: JanKoehnlein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5e232e8 into main Aug 10, 2021
@roboquat roboquat deleted the wth/revert-7826291 branch August 10, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants