Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(install): retire broken docker installation instructions #5145

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

ghuntley
Copy link
Contributor

Related to #5144.

I'm all for a /install/ folder and these docker installation instructions but currently they lead people down the wrong path because the contents are not supported/maintained.

@ghuntley ghuntley added the component: install Terraform installation scripts, helm charts, installer images label Aug 11, 2021
@roboquat roboquat requested a review from aledbf August 11, 2021 06:03
@corneliusludmann
Copy link
Contributor

At least the install/docker thing is something that I maintain (and use) currently. That should work at least for the 0.10.0 release. If we really want to drop it from this repo I would create an additional repo to maintain it there.

@ghuntley
Copy link
Contributor Author

ghuntley commented Aug 28, 2021

At least the install/docker thing is something that I maintain (and use) currently. That should work at least for the 0.10.0 release. If we really want to drop it from this repo I would create an additional repo to maintain it there.

💭 let's relocate install/docker to contrib/docker?

  • removes the confusion about install/
  • removes the need to manage an additional repo
  • enables maintaining it (something that is desired)

Yay/Nay?

edit: additionally - I would <3 to see the contents of install/docker promoted to a first-class citizen that is supported @mrsimonemms.

@corneliusludmann
Copy link
Contributor

let's relocate install/docker to contrib/docker?

Sounds great!

additionally - I would <3 to see the contents of install/docker promoted to a first-class citizen that is supported

+1

@ghuntley
Copy link
Contributor Author

ghuntley commented Sep 1, 2021

install/docker relocated to contrib/docker but the build is failing. I need a werft/leeway consult to fix ❤️.

/werft with-contrib
@roboquat roboquat added size/M and removed size/S labels Sep 1, 2021
@corneliusludmann
Copy link
Contributor

@ghuntley Took the liberty and pushed a commit that fixes the werft/leeway issue. Feel free to squash with your commit and let me know whether this is ready for review.

By the way: Currently, the stuff in contrib will be built only when the /werft with-contrib (was /werft with-installer) command has been added to the most recent commit or to the pull request.

@ghuntley
Copy link
Contributor Author

ghuntley commented Sep 2, 2021

@ghuntley Took the liberty and pushed a commit that fixes the werft/leeway issue. Feel free to squash with your commit and let me know whether this is ready for review.

@ghuntley
Copy link
Contributor Author

ghuntley commented Sep 2, 2021

LGTM - do the magic /approve no-issue and lets go!

@corneliusludmann
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 2, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

LGTM label has been added.

Git tree hash: 84ad4c48839dbb61479864fb3e82cdd5204fb378

@corneliusludmann
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusludmann

Associated issue requirement bypassed by: corneliusludmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 2c70b97 into main Sep 2, 2021
@roboquat roboquat deleted the gh/docker branch September 2, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: install Terraform installation scripts, helm charts, installer images size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants