Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-daemon] Remove Containerd4214 workaround #5153

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

csweichel
Copy link
Contributor

Reverts #4930

Turns out this "workaround" is hiding more issues that it solves.

@roboquat roboquat requested a review from aledbf August 11, 2021 14:17
@csweichel csweichel changed the title Revert "Revert "[ws-daemon] Remove Containerd4214 workaround"" [ws-daemon] Remove Containerd4214 workaround Aug 11, 2021
@aledbf
Copy link
Member

aledbf commented Aug 11, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: c43d938a120e9185bb39ce9533763010117c497e

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #4930

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #5153 (1489400) into main (877ec73) will increase coverage by 22.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5153       +/-   ##
=========================================
+ Coverage      0   22.98%   +22.98%     
=========================================
  Files         0       11       +11     
  Lines         0     1919     +1919     
=========================================
+ Hits          0      441      +441     
- Misses        0     1419     +1419     
- Partials      0       59       +59     
Flag Coverage Δ
components-ws-daemon-app 22.98% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-daemon/pkg/quota/size.go 87.30% <0.00%> (ø)
components/ws-daemon/pkg/resources/limiter.go 77.77% <0.00%> (ø)
components/ws-daemon/pkg/resources/controller.go 33.69% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go 19.38% <0.00%> (ø)
components/ws-daemon/pkg/content/tar.go 45.63% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go 50.73% <0.00%> (ø)
components/ws-daemon/pkg/content/archive.go 57.47% <0.00%> (ø)
components/ws-daemon/pkg/content/config.go 62.50% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877ec73...1489400. Read the comment docs.

@roboquat roboquat merged commit 1c47047 into main Aug 11, 2021
@roboquat roboquat deleted the revert-4930-revert-4683-aledbf/retag branch August 11, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants