Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent-smith] Do not log errors for processes not running #5162

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 12, 2021

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @csweichel

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5162 (649cc28) into main (8f867ae) will increase coverage by 6.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5162      +/-   ##
==========================================
+ Coverage   19.44%   26.05%   +6.61%     
==========================================
  Files          14        5       -9     
  Lines        2510      783    -1727     
==========================================
- Hits          488      204     -284     
+ Misses       1960      556    -1404     
+ Partials       62       23      -39     
Flag Coverage Δ
components-ee-agent-smith-app 26.05% <0.00%> (?)
components-workspacekit-app ?
components-ws-daemon-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/agent-smith/pkg/agent/agent.go 18.97% <0.00%> (ø)
components/workspacekit/cmd/lift.go
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/content/initializer.go
components/ws-daemon/pkg/content/archive.go
components/workspacekit/cmd/rings.go
components/ws-daemon/pkg/content/service.go
components/ws-daemon/pkg/internal/session/store.go
components/workspacekit/cmd/root.go
components/ws-daemon/pkg/content/tar.go
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f867ae...649cc28. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 12, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 467d5deec60c183546d8de583be28032ba4a7ea9

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/approve

@csweichel
Copy link
Contributor

/lgtm

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

/assign @leodido

@aledbf
Copy link
Member Author

aledbf commented Aug 12, 2021

@leodido searching for an approval :)

Copy link
Contributor

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aledbf
Copy link
Member Author

aledbf commented Aug 13, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel, leodido

Associated issue requirement bypassed by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a0baa60 into main Aug 13, 2021
@roboquat roboquat deleted the aledbf/agentskip branch August 13, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants