Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Add George as a dashboard OWNER #5192

Merged
merged 1 commit into from
Sep 4, 2021
Merged

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Aug 13, 2021

Thanks for the consistently outstanding PRs and code reviews @gtsiolis! πŸŽ–οΈ 🎯

I don't see why @roboquat won't let you approve dashboard Pull Requests. I vote more power to you! 😁 πŸš€

(Alternatively, we could create a ux or product team in https://github.com/gitpod-io/gitpod/blob/main/OWNERS_ALIASES, but we can also do that later.)

@jankeromnes
Copy link
Contributor Author

This PR is NOT APPROVED

please ask for approval from jankeromnes after the PR has been reviewed

Lol, I approve my own PR!

/approve no-issue

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jankeromnes! 🧑

⬆️ For more context in case anyone reads this, I can still approve changes but @roboquat won't allow merging these PRs without an extra approval from someone from the engineering team (see engineering-meta). We could merge this if this could help us move faster and better as a team, especially since we currently have basic triage operations and code review workflows. πŸ€–

🚨 If we merge this I may have to be a bit more frugal with PR approvals and loop in others when a deeper dive into the code changes is needed as well as make good use of labels like do-not-merge/hold. 🀠

⬇️ However, I'm also fine with not being part of the approvers as most of the times we'll also need a review from someone else who can take a deeper dive into the code changes besides the ones affecting the visual aspect of the changes. πŸ–οΈ

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course!

@roboquat
Copy link
Contributor

roboquat commented Sep 4, 2021

LGTM label has been added.

Git tree hash: c033eba33f4b8597054182d86809278916d24921

@roboquat
Copy link
Contributor

roboquat commented Sep 4, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes, svenefftinge

Associated issue requirement bypassed by: jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 71cb39f into main Sep 4, 2021
@roboquat roboquat deleted the jx/gtsiolis-rocks branch September 4, 2021 07:03
@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 6, 2021

Thanks, everyone! πŸ™‚

artworks-000583566434-tws230-t500x500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants