Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeconfig of dev image to new core-dev cluster #5219

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

princerachit
Copy link
Contributor

@princerachit princerachit commented Aug 16, 2021

No description provided.

@geropl
Copy link
Member

geropl commented Aug 16, 2021

@princerachit This will fix the issues inside the workspace. But we should also update all other places where this image is used. Search and replace dev-environment:geropl-move-qemu-image-build-to-4945.3 with a build from this branch.

@princerachit
Copy link
Contributor Author

princerachit commented Aug 16, 2021

/werft run

👍 started the job as gitpod-build-prs-core-dev-kubeconfig.1

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@roboquat roboquat added size/M and removed size/S labels Aug 16, 2021
@princerachit
Copy link
Contributor Author

The new image works:
image

@princerachit
Copy link
Contributor Author

princerachit commented Aug 16, 2021

/werft run

👍 started the job as gitpod-build-prs-core-dev-kubeconfig.3

@geropl
Copy link
Member

geropl commented Aug 16, 2021

/approved no-issue

dev/image/kubeconfig.yaml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #5219 (8986f97) into main (9eacb7d) will increase coverage by 31.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5219       +/-   ##
=========================================
+ Coverage      0   31.48%   +31.48%     
=========================================
  Files         0       35       +35     
  Lines         0     5821     +5821     
=========================================
+ Hits          0     1833     +1833     
- Misses        0     3841     +3841     
- Partials      0      147      +147     
Flag Coverage Δ
components-ee-agent-smith-app 26.05% <ø> (?)
components-gitpod-cli-app 9.74% <ø> (?)
components-gitpod-protocol-go-lib ∅ <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-supervisor-app 37.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
components/supervisor/pkg/supervisor/services.go 25.50% <0.00%> (ø)
...omponents/ee/agent-smith/pkg/signature/sinature.go 44.27% <0.00%> (ø)
components/supervisor/pkg/ports/ports-config.go 79.85% <0.00%> (ø)
components/gitpod-cli/cmd/env.go 14.41% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/actions.go 0.00% <0.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go 45.65% <0.00%> (ø)
components/gitpod-cli/cmd/await-port.go 8.00% <0.00%> (ø)
components/ee/agent-smith/pkg/agent/agent.go 18.97% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eacb7d...8986f97. Read the comment docs.

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

cluster: gke_gitpod-core-dev_europe-west1-b_dev
user: gke_gitpod-core-dev_europe-west1-b_dev
cluster: gke_gitpod-core-dev_europe-west1-b_core-dev
user: gke_gitpod-core-dev_europe-west1-b_core-dev
name: dev
current-context: dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roboquat roboquat added the lgtm label Aug 16, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc54c611e143d72e79f876164005adc302e8c409

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: geropl

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 56ae452 into main Aug 17, 2021
@roboquat roboquat deleted the prs/core-dev-kubeconfig branch August 17, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants