Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blobserve] Catch panic in HTTP requests #5241

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Aug 17, 2021

We get some panic errors in blobserve from time to time. However, the log messages from net/http are not very helpful (see #5232).

This change catches the panic errors and adds proper logs like this:

Screenshot_2021-08-17_17-11-34

(here tested with this temp. change: 9c7e551)

Hopefully, this change will help to find the proper segment fault.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #5241 (9c7e551) into main (e0f5b36) will increase coverage by 28.17%.
The diff coverage is 0.00%.

❗ Current head 9c7e551 differs from pull request most recent head 09f8687. Consider uploading reports for the commit 09f8687 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5241       +/-   ##
=========================================
+ Coverage      0   28.17%   +28.17%     
=========================================
  Files         0        3        +3     
  Lines         0      536      +536     
=========================================
+ Hits          0      151      +151     
- Misses        0      368      +368     
- Partials      0       17       +17     
Flag Coverage Δ
components-blobserve-app 28.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/blobserve/pkg/blobserve/blobserve.go 7.97% <0.00%> (ø)
components/blobserve/pkg/blobserve/refstore.go 63.02% <0.00%> (ø)
components/blobserve/pkg/blobserve/blobspace.go 9.39% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f5b36...09f8687. Read the comment docs.

@corneliusludmann
Copy link
Contributor Author

@JanKoehnlein Here is the solution we discussed. WDYT?

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3ee459491c9b2f5614a143bb49b35f17d4f6934

@aledbf
Copy link
Member

aledbf commented Aug 17, 2021

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, JanKoehnlein

Associated issue: #5232

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 97c166e into main Aug 17, 2021
@roboquat roboquat deleted the clu/segfault-in-blobserve-5232 branch August 17, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants