Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Add liveness probe to ws-proxy deployment #5286

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

princerachit
Copy link
Contributor

No description provided.

@geropl
Copy link
Member

geropl commented Aug 24, 2021

Just curious: What's the motivation to add the probe here?

@princerachit
Copy link
Contributor Author

Just curious: What's the motivation to add the probe here?

It is considered a good practice to have both liveness and readiness probes defined.
It is a prerequisite to force google load balancer to use only the nodes as backend which has this pod scheduled on them

@geropl
Copy link
Member

geropl commented Aug 31, 2021

It is a prerequisite to force google load balancer to use only the nodes as backend which has this pod scheduled on them

Ah, that's interesting, thanks!

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a8b9ee2373f7eeecebbc1ce291f57c0da01b1ce

@geropl
Copy link
Member

geropl commented Aug 31, 2021

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 19d859c into main Aug 31, 2021
@roboquat roboquat deleted the prs/ws-proxy-liveness-probe branch August 31, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants