Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] smooth VS Code desktop flow #5287

Merged
merged 2 commits into from
Aug 23, 2021
Merged

[code] smooth VS Code desktop flow #5287

merged 2 commits into from
Aug 23, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 20, 2021

What it does

fix #4780

Changes in Gitpod Code: gitpod-io/openvscode-server@b1465c2

How to test

Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really well. The only thing I noticed was that the terminals didn't open as in the web version (I was using insider).

@roboquat roboquat added the lgtm label Aug 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 90ee29e529c8f5ea5406345d03a09f78a16652e6

@akosyakov
Copy link
Member Author

/approve

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, svenefftinge

Associated issue: #4780

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 2a881ef into main Aug 23, 2021
@roboquat roboquat deleted the ak/vscode_desktop branch August 23, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local VS Code support
4 participants