Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supervisor] Remove misleading error message #5293

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 20, 2021

During the workspace disposal process, we see a message error triggered by closing the context.

...
{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","error":"context canceled","level":"error","message":"cannot provide Docker activation socket","serviceContext":{"service":"supervisor","version":""},"severity":"ERROR","time":"2021-08-18T11:46:37Z"}

xref: #5240

@roboquat roboquat requested a review from fntlnz August 20, 2021 12:27
@aledbf
Copy link
Member Author

aledbf commented Aug 20, 2021

/assign @akosyakov

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #5293 (3a1f0eb) into main (58f0b33) will increase coverage by 37.61%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5293       +/-   ##
=========================================
+ Coverage      0   37.61%   +37.61%     
=========================================
  Files         0       16       +16     
  Lines         0     4099     +4099     
=========================================
+ Hits          0     1542     +1542     
- Misses        0     2432     +2432     
- Partials      0      125      +125     
Flag Coverage Δ
components-supervisor-app 37.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/supervisor.go 6.41% <0.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/supervisor/pkg/ports/exposed-ports.go 0.00% <0.00%> (ø)
components/supervisor/pkg/ports/ports.go 60.03% <0.00%> (ø)
components/supervisor/pkg/terminal/terminal.go 63.27% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 76.00% <0.00%> (ø)
components/supervisor/pkg/supervisor/user.go 33.12% <0.00%> (ø)
components/supervisor/pkg/terminal/ring-buffer.go 45.65% <0.00%> (ø)
components/supervisor/pkg/supervisor/config.go 4.51% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f0b33...3a1f0eb. Read the comment docs.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@roboquat roboquat added the lgtm label Aug 20, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: fc93c7b4e3c67584cf17dd0677c1464c8e32490d

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue: #5240

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 98a7dc7 into main Aug 20, 2021
@roboquat roboquat deleted the aledbf/deadline branch August 20, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants