Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspacekit] Close lift unix socket on termination #5296

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 20, 2021

No description provided.

@aledbf
Copy link
Member Author

aledbf commented Aug 20, 2021

/assign @akosyakov

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #5296 (9f0b813) into main (58f0b33) will increase coverage by 7.50%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #5296      +/-   ##
=======================================
+ Coverage      0   7.50%   +7.50%     
=======================================
  Files         0       3       +3     
  Lines         0     586     +586     
=======================================
+ Hits          0      44      +44     
- Misses        0     539     +539     
- Partials      0       3       +3     
Flag Coverage Δ
components-workspacekit-app 7.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/workspacekit/cmd/rings.go 7.39% <0.00%> (ø)
components/workspacekit/cmd/root.go 0.00% <0.00%> (ø)
components/workspacekit/cmd/lift.go 18.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58f0b33...9f0b813. Read the comment docs.

Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve no-issue

makes sense, than you

@roboquat roboquat added the lgtm label Aug 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 074d550ac778d846cd6fa72d3cfd25f704b7b9ff

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit f647b66 into main Aug 23, 2021
@roboquat roboquat deleted the aledbf/lift branch August 23, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants