-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-daemon] Pass error by value instead of reference #5358
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5358 +/- ##
=========================================
+ Coverage 0 23.17% +23.17%
=========================================
Files 0 11 +11
Lines 0 1929 +1929
=========================================
+ Hits 0 447 +447
- Misses 0 1423 +1423
- Partials 0 59 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
e82fe47
to
5e361ec
Compare
I tested this in preview env and it works as expected. I request the reviewers to test out this PR . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this fixes the issue when saving changes 🥳
LGTM label has been added. Git tree hash: e4142c096ba63c675e862ec26375bcbaa82a727f
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrSimonEmms Associated issue: #5349 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #5349