[ws-daemon] Pass error by value instead of reference

[princerachit]

fixes #5349

[codecov]

Codecov Report

Merging #5358 (5e361ec) into main (f646642) will increase coverage by 23.17%.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           main    #5358       +/-   ##
=========================================
+ Coverage      0   23.17%   +23.17%     
=========================================
  Files         0       11       +11     
  Lines         0     1929     +1929     
=========================================
+ Hits          0      447      +447     
- Misses        0     1423     +1423     
- Partials      0       59       +59     

Flag	Coverage Δ
components-ws-daemon-app	23.17% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-daemon/pkg/content/archive.go	58.88% <66.66%> (ø)
components/ws-daemon/pkg/content/tar.go	46.71% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go	0.00% <0.00%> (ø)
components/ws-daemon/pkg/resources/dispatch.go	0.00% <0.00%> (ø)
components/ws-daemon/pkg/internal/session/store.go	19.38% <0.00%> (ø)
...onents/ws-daemon/pkg/internal/session/workspace.go	50.73% <0.00%> (ø)
components/ws-daemon/pkg/quota/size.go	87.30% <0.00%> (ø)
components/ws-daemon/pkg/resources/controller.go	33.69% <0.00%> (ø)
components/ws-daemon/pkg/content/initializer.go	0.00% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f646642...5e361ec. Read the comment docs.

[princerachit]

I tested this in preview env and it works as expected. I request the reviewers to test out this PR .

[mrsimonemms]

Confirmed this fixes the issue when saving changes 🥳

[roboquat]

LGTM label has been added.

Git tree hash: e4142c096ba63c675e862ec26375bcbaa82a727f

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrSimonEmms

Associated issue: #5349

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/ws-daemon/OWNERS [MrSimonEmms]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment