Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-environment] Update dependencies #5383

Merged
merged 5 commits into from
Aug 27, 2021
Merged

[dev-environment] Update dependencies #5383

merged 5 commits into from
Aug 27, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 25, 2021

Changes:

  • Update workspace image (go 1.17)
  • golangci-lint.sh v1.42.0
  • google-cloud-sdk 354.0.0
  • aws-iam-authenticator v1.21
  • Update go dependencies for go 1.17

Go changes https://go.dev/blog/go1.17

@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

/hold

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@roboquat roboquat added size/XXL and removed size/S labels Aug 25, 2021
@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

/werft run

👍 started the job as gitpod-build-aledbf-deve.6

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #5383 (9dfcc22) into main (a1da634) will increase coverage by 4.55%.
The diff coverage is n/a.

❗ Current head 9dfcc22 differs from pull request most recent head 9a05b08. Consider uploading reports for the commit 9a05b08 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5383      +/-   ##
==========================================
+ Coverage   31.77%   36.32%   +4.55%     
==========================================
  Files          24       13      -11     
  Lines        5697     3752    -1945     
==========================================
- Hits         1810     1363     -447     
+ Misses       3713     2274    -1439     
+ Partials      174      115      -59     
Flag Coverage Δ
components-ws-daemon-app ?
components-ws-manager-app 36.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ws-manager/pkg/manager/manager_ee.go 0.00% <ø> (ø)
components/ws-daemon/pkg/resources/limiter.go
components/ws-daemon/pkg/content/archive.go
components/ws-daemon/pkg/content/service.go
components/ws-daemon/pkg/content/tar.go
components/ws-daemon/pkg/resources/dispatch.go
...onents/ws-daemon/pkg/internal/session/workspace.go
components/ws-daemon/pkg/quota/size.go
components/ws-daemon/pkg/resources/controller.go
components/ws-daemon/pkg/content/config.go
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1da634...9a05b08. Read the comment docs.

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@github-actions
Copy link
Contributor

⚠️ Hew reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harfmul.

@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Aug 25, 2021

/hold cancel

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 27, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee500a12c83eb3ebcce0e9033f07f3254ce34f45

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3218858 into main Aug 27, 2021
@roboquat roboquat deleted the aledbf/deve branch August 27, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants