-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ws-proxy] Remove proxy of ws-manager #5400
Conversation
/assign @csweichel |
/hold |
Codecov Report
@@ Coverage Diff @@
## main #5400 +/- ##
=========================================
+ Coverage 0 66.30% +66.30%
=========================================
Files 0 8 +8
Lines 0 1285 +1285
=========================================
+ Hits 0 852 +852
- Misses 0 374 +374
- Partials 0 59 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@csweichel @meysholdt can we merge this change? After merging the change, the access to cluster through |
/assign @meysholdt |
/hold cancel |
is there a corresponding -com PR? |
There is no need? The change of the type to LoadBalancer will create the required Cloud load balancer. |
Makes sense - I just don't see where that change happens. |
Sorry. You are right. Here https://github.com/gitpod-io/ops/pull/20 |
merged /lgtm |
LGTM label has been added. Git tree hash: bda27cac802dfbf2ef74267c931236dc72532ca2
|
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue requirement bypassed by: csweichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a proposal to remove the proxy of
ws-manager
throughws-proxy
.Reasons:
ws-proxy
. Using TLS termination in the load balancer breaks this feature.ws-manager
behindws-proxy
and is really hard to troubleshoot/debug.If we need to expose ws-manager in workspace clusters we should use a service
type=LoadBalancer