Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in root.go #5419

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Fix typo in root.go #5419

merged 1 commit into from
Aug 27, 2021

Conversation

jwpjrdev
Copy link
Contributor

No description provided.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 88163320de15494c8b2a11418de503a91d5d34be

@svenefftinge
Copy link
Member

/approve no-issue

@svenefftinge
Copy link
Member

svenefftinge commented Aug 27, 2021

/werft run

👍 started the job as gitpod-build-patch-1-fork.5

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #5419 (aef163d) into main (92cb2c7) will increase coverage by 2.52%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #5419      +/-   ##
========================================
+ Coverage   7.22%   9.74%   +2.52%     
========================================
  Files          3      14      +11     
  Lines        609     954     +345     
========================================
+ Hits          44      93      +49     
- Misses       562     860     +298     
+ Partials       3       1       -2     
Flag Coverage Δ
components-gitpod-cli-app 9.74% <ø> (?)
components-workspacekit-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/root.go 0.00% <ø> (ø)
components/workspacekit/cmd/lift.go
components/workspacekit/cmd/root.go
components/workspacekit/cmd/rings.go
components/gitpod-cli/cmd/sync-await.go 10.52% <0.00%> (ø)
components/gitpod-cli/cmd/sync-done.go 12.50% <0.00%> (ø)
components/gitpod-cli/cmd/completion.go 40.00% <0.00%> (ø)
components/gitpod-cli/cmd/forward-port.go 7.50% <0.00%> (ø)
components/gitpod-cli/cmd/preview.go 32.14% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92cb2c7...aef163d. Read the comment docs.

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, svenefftinge

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit e039c1b into gitpod-io:main Aug 27, 2021
@jwpjrdev jwpjrdev deleted the patch-1 branch August 28, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants