Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projects] add check for createProject #5421

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

AlexTugarev
Copy link
Member

No description provided.

@geropl
Copy link
Member

geropl commented Sep 6, 2021

@AlexTugarev is this still relevant/already done?

@AlexTugarev
Copy link
Member Author

@geropl, yes this is very relevant. I just updated the branch.

cloneUrl: repo.cloneUrl,
account: repo.account,
provider,
...(User.is(teamOrUser) ? { userId: teamOrUser.id } : { teamId: teamOrUser.id }),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to blink twise 🙂

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: d85c125210e0c7451447a8e6dc54e40c668799cd

@AlexTugarev
Copy link
Member Author

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, geropl

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 797e15c into main Sep 14, 2021
@roboquat roboquat deleted the at/check-createproject branch September 14, 2021 10:31
@gtsiolis gtsiolis added feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. component: dashboard labels Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants