Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable VS Code Desktop for stable #5434

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Aug 30, 2021

  • /werft with-clean-slate-deployment

What it does

VS Code Desktop is not ready yet to be available for everyone. This PR enables it only on latest.

Changes in Gitpod Code: gitpod-io/openvscode-server@330c9b3

How to test

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #5434 (6aa0c62) into main (057c424) will increase coverage by 32.19%.
The diff coverage is 33.33%.

❗ Current head 6aa0c62 differs from pull request most recent head 2e04d7f. Consider uploading reports for the commit 2e04d7f to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5434       +/-   ##
=========================================
+ Coverage      0   32.19%   +32.19%     
=========================================
  Files         0       46       +46     
  Lines         0     9786     +9786     
=========================================
+ Hits          0     3151     +3151     
- Misses        0     6381     +6381     
- Partials      0      254      +254     
Flag Coverage Δ
components-gitpod-cli-app 9.74% <ø> (?)
components-image-builder-mk3-app 6.72% <ø> (?)
components-local-app-app-darwin ∅ <ø> (?)
components-local-app-app-linux ∅ <ø> (?)
components-local-app-app-windows ∅ <ø> (?)
components-supervisor-app 37.65% <0.00%> (?)
components-ws-manager-app 38.35% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/supervisor/pkg/supervisor/config.go 4.51% <ø> (ø)
components/supervisor/pkg/supervisor/services.go 25.34% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 78.83% <100.00%> (ø)
components/supervisor/pkg/ports/tunnel.go 63.63% <0.00%> (ø)
components/supervisor/pkg/supervisor/user.go 33.12% <0.00%> (ø)
components/gitpod-cli/cmd/sync-done.go 12.50% <0.00%> (ø)
components/ws-manager/pkg/manager/manager_ee.go 0.00% <0.00%> (ø)
components/gitpod-cli/cmd/git-token-validator.go 13.20% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go 74.46% <0.00%> (ø)
components/supervisor/pkg/ports/served-ports.go 76.00% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 057c424...2e04d7f. Read the comment docs.

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81ea533ba9e87b7f86c15ea43a261d9afa62364c

@roboquat roboquat removed the lgtm label Aug 30, 2021
@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Aug 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 81ea533ba9e87b7f86c15ea43a261d9afa62364c

@akosyakov
Copy link
Member Author

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 4044baf into main Aug 30, 2021
@roboquat roboquat deleted the ak/no_code_desktop_in_stable branch August 30, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants