[db] Subscribe existing users to DevXMail

[laushinka]

Users who were subscribed to Changelog will also be subscribed
to DevX.

Fixes #5315

[JanKoehnlein]

/uncc @atduarte
/cc @jakobhero
/cc @AlexTugarev

Do we know how long such a migration would run? Would it make sense to merge that with #5439 ?

[JanKoehnlein]

/hold

Let's not jeopardize today's deployment. If reviewers are sure it is harmless, unhold.

[atduarte]

According to the following query, 116 users unsubscribed from the DevX emails making it impractical to manually unsubscribe them:

SELECT user_id, 
  ARRAY_AGG(unsubscribed_devx ORDER BY uuid_ts DESC)[OFFSET(0)] AS unsubscribed_devx_
FROM `gitpod-growth.production_trusted.notification_change`
WHERE unsubscribed_devx IS NOT NULL
GROUP BY user_id
HAVING unsubscribed_devx_ = true;

Could we change the migration to take this into consideration?

Also, just as a reminder: synchronization with customer.io happens through signup/notification_change/deletion segment events. So this change won't be represented in customer.io until we manually import it.

[laushinka]

According to the following query, 116 users unsubscribed from the DevX emails making it impractical to manually unsubscribe them:

@atduarte This is unfortunate. Did the 116 happen in these two weeks? If yes then it will be impractical to manually change them, and the DB doesn't reflect how the values changed - we can't know whether the unsubscribed_devx was due to a user unchecking the box. @ChristinFrohne what do you say?

[chrifro]

We have sent a DevX Digest on August 26. The newsletter had 1,092 total clicks on https://gitpod.io/notifications. So it seems a bit weird that "only" 116 users unsubscribed from the DevX email. But also possible as the link requires logging in and maybe most gave up on the way. Also, I don't know the number of unique clicks, might be that some users clicked several times on the link.

we can't know whether the unsubscribed_devx was due to a user unchecking the box. @ChristinFrohne what do you say?

Yes, that's very likely as we sent a DevX email within the last 14 days. Also what other way would be possible to unsubscribe? @laushinka

[atduarte]

Users that unsubscribed from DevX will have the AllowDevXMail as false in the database. As such, I believe the easiest approach is to change this query to only update users where the AllowDevXMail property is not defined.

[atduarte]

/approve

[JanKoehnlein]

/unhold

[laushinka]

@JanKoehnlein Apologies for the scope creep request, but @ChristinFrohne saw that this onboarding mail isn't active for existing users, therefore it should be activated for all - similar to what this PR is doing for another mail. Would it be okay that I add this change to this PR as well?

[JanKoehnlein]

@laushinka sure. The less DB migrations we have to do the better. And AFAIKS it does neither add any completely different functionality nor raise other concerns.

[laushinka]

Ready for re-review @atduarte @JanKoehnlein

[atduarte]

/approve

[JanKoehnlein]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 813f78f4d3314d5084cd4bdc2a3ba66f3cd2bd6f

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atduarte, JanKoehnlein

Associated issue: #5315

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/gitpod-db/OWNERS [JanKoehnlein]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment