Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplication of GRPC configuration #5447

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Remove duplication of GRPC configuration #5447

merged 2 commits into from
Sep 1, 2021

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 30, 2021

fixes #5446

@aledbf
Copy link
Member Author

aledbf commented Aug 30, 2021

/assign @csweichel


// maxMsgSize use 16MB as the default message size limit.
// grpc library default is 4MB
const maxMsgSize = 1024 * 1024 * 16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason to adjust this value is related to some observed metrics that could indicate the current value is low.
grpc_server_handled_total{grpc_code="ResourceExhausted",grpc_method="StartWorkspace",grpc_service="wsman.WorkspaceManager",grpc_type="unary"} 8

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #5447 (67c9a29) into main (4044baf) will increase coverage by 32.55%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #5447       +/-   ##
=========================================
+ Coverage      0   32.55%   +32.55%     
=========================================
  Files         0      105      +105     
  Lines         0    20473    +20473     
=========================================
+ Hits          0     6666     +6666     
- Misses        0    13217    +13217     
- Partials      0      590      +590     
Flag Coverage Δ
components-blobserve-app 28.38% <ø> (?)
components-common-go-lib 30.71% <ø> (?)
components-content-service-api-go-lib ∅ <ø> (?)
components-content-service-app 14.44% <ø> (?)
components-content-service-lib 14.44% <ø> (?)
components-ee-agent-smith-app 25.82% <ø> (?)
components-ee-kedge-app 45.48% <ø> (?)
components-ee-ws-scheduler-app 63.16% <0.00%> (?)
components-image-builder-api-go-lib ∅ <ø> (?)
components-image-builder-app 34.44% <ø> (?)
components-image-builder-bob-app ∅ <ø> (?)
components-image-builder-mk3-app 6.75% <0.00%> (?)
components-registry-facade-app 11.67% <0.00%> (?)
components-registry-facade-lib 11.67% <0.00%> (?)
components-service-waiter-app ∅ <ø> (?)
components-supervisor-app 37.46% <ø> (?)
components-workspacekit-app 7.22% <ø> (?)
components-ws-daemon-api-go-lib ∅ <ø> (?)
components-ws-daemon-app 22.98% <ø> (?)
components-ws-daemon-nsinsider-app ∅ <ø> (?)
components-ws-manager-api-go-lib ∅ <ø> (?)
components-ws-manager-app 38.18% <50.00%> (?)
components-ws-proxy-app 66.87% <0.00%> (?)
dev-loadgen-app ∅ <ø> (?)
dev-poolkeeper-app ∅ <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/ee/ws-scheduler/pkg/scaler/driver.go 49.84% <0.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go 0.00% <0.00%> (ø)
...omponents/registry-facade/pkg/registry/registry.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/infoprovider.go 49.31% <0.00%> (ø)
components/ws-manager/pkg/manager/manager.go 24.06% <50.00%> (ø)
components/supervisor/pkg/supervisor/git.go 0.00% <0.00%> (ø)
components/ws-daemon/pkg/content/service.go 0.00% <0.00%> (ø)
components/content-service/pkg/storage/noop.go 0.00% <0.00%> (ø)
components/ee/ws-scheduler/pkg/scheduler/state.go 91.44% <0.00%> (ø)
components/ws-manager/pkg/manager/create.go 78.83% <0.00%> (ø)
... and 100 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4044baf...67c9a29. Read the comment docs.

@csweichel
Copy link
Contributor

Love the approach. Two comments:

  1. In a follow up we could harmonise the TLS handling across the components, too. Right now we have all the TLS code - esp. on the client side - strewn across the components.
  2. What about the TS components? It would probably make sense to introduce a similar mechanism in gitpod-protocol, no?

@aledbf
Copy link
Member Author

aledbf commented Aug 31, 2021

Love the approach. Two comments:

  1. In a follow up we could harmonise the TLS handling across the components, too. Right now we have all the TLS code - esp. on the client side - strewn across the components.

Yes, I saw that ;)

  1. What about the TS components? It would probably make sense to introduce a similar mechanism in gitpod-protocol, no?

Already WIP #5449

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 1, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

LGTM label has been added.

Git tree hash: 10fd1fcd8c86303410072362baed566bc52c16fc

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5446

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 9fd31ef into main Sep 1, 2021
@roboquat roboquat deleted the aledbf/grpcdo branch September 1, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplication of GRPC configuration (client and server)
3 participants