-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplication of GRPC configuration #5447
Conversation
/assign @csweichel |
|
||
// maxMsgSize use 16MB as the default message size limit. | ||
// grpc library default is 4MB | ||
const maxMsgSize = 1024 * 1024 * 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason to adjust this value is related to some observed metrics that could indicate the current value is low.
grpc_server_handled_total{grpc_code="ResourceExhausted",grpc_method="StartWorkspace",grpc_service="wsman.WorkspaceManager",grpc_type="unary"} 8
Codecov Report
@@ Coverage Diff @@
## main #5447 +/- ##
=========================================
+ Coverage 0 32.55% +32.55%
=========================================
Files 0 105 +105
Lines 0 20473 +20473
=========================================
+ Hits 0 6666 +6666
- Misses 0 13217 +13217
- Partials 0 590 +590
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Love the approach. Two comments:
|
Yes, I saw that ;)
Already WIP #5449 |
/lgtm |
LGTM label has been added. Git tree hash: 10fd1fcd8c86303410072362baed566bc52c16fc
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csweichel Associated issue: #5446 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes #5446