vscode desktop on windows

[akosyakov]

What it does

fix #5437: It is a set of small changes to the local app to track down issues on windows.

The underlying issue was that tmp npm module tracks all temp files by default and delete them on process exit. On windows it will lock files and prevent starting the local app or opening a new window. I reconfigured the library that it does not keep and immediately release the file descriptor. Plus added a way to use the user download local app, enable verbose logging and cancel the window opening if it hangs. The real fix was done here: gitpod-io/openvscode-server@1f70305 and already published to the marketplace.

How to test

There is no really anything to test in prev env. You can try to use Windows machine in the production to open VS Code Desktop from latest VS Code Web. Or just merge it 😉

[codecov]

Codecov Report

Merging #5456 (80d7b8b) into main (f66598c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5456   +/-   ##
=======================================
  Coverage   19.39%   19.39%           
=======================================
  Files           2        2           
  Lines         165      165           
=======================================
  Hits           32       32           
  Misses        131      131           
  Partials        2        2           

Flag	Coverage Δ
components-local-app-app-linux	19.39% <ø> (ø)
components-local-app-app-windows	∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f66598c...80d7b8b. Read the comment docs.

[akosyakov]

/werft run

👍 started the job as gitpod-build-ak-local-app-win.2

[JanKoehnlein]

Tried it spawning up my windows VM after about a year, and it works!

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 0e8d094ce5e5031cd4818bd927593246e1eff7b3

[akosyakov]

/assign @rl-gitpod

[akosyakov]

/approve

[akosyakov]

@rl-gitpod Could you approve please?

[rl-gitpod]

/approve

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, JanKoehnlein, rl-gitpod

Associated issue: #5437

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/local-app/OWNERS [rl-gitpod]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment