Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] automated changelog extraction #5462

Merged
merged 3 commits into from
Sep 8, 2021
Merged

[build] automated changelog extraction #5462

merged 3 commits into from
Sep 8, 2021

Conversation

JanKoehnlein
Copy link
Contributor

First shot at the changelog automation

/hold

@JanKoehnlein
Copy link
Contributor Author

Here's the first shot at the changelog automation based on werft for review. You can take it for a spin on https://github.com/gitpod-io/gitpod-test-repo.

I need a bit more input on a few topics

  1. I don't really know as which user the CHANGELOG.md should be committed
  2. Currently the new changelog file is pushed directly to master. That could cause conflicts with concurrent builds and PR merges. We should maybe rather use PRs, but then somebody has to merge these and we have to find out which branch to use. When we switch to PRs, how do we choose the branch name?

@JanKoehnlein
Copy link
Contributor Author

/cc @csweichel

@JanKoehnlein
Copy link
Contributor Author

/uncc @mrsimonemms

@roboquat roboquat removed the request for review from mrsimonemms August 31, 2021 15:22
@JanKoehnlein JanKoehnlein force-pushed the jk/changelog branch 3 times, most recently from cf454f9 to 45bb305 Compare September 2, 2021 12:17
@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 2, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

LGTM label has been added.

Git tree hash: 512aedc6fe0f02f6d45890f9e83ac6e0c14b126e

@csweichel
Copy link
Contributor

/approve no-issue

@roboquat roboquat removed the lgtm label Sep 3, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 3, 2021

New changes are detected. LGTM label has been removed.

@JanKoehnlein JanKoehnlein force-pushed the jk/changelog branch 2 times, most recently from e9ff0ed to 0f87ad9 Compare September 3, 2021 09:40
@JanKoehnlein
Copy link
Contributor Author

/approve

@roboquat
Copy link
Contributor

roboquat commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel, JanKoehnlein

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JanKoehnlein,csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JanKoehnlein
Copy link
Contributor Author

@csweichel Let's merge this after the Engineering sync on Monday

@JanKoehnlein JanKoehnlein force-pushed the jk/changelog branch 2 times, most recently from 9fba2cb to 964c8e7 Compare September 3, 2021 12:41
@JanKoehnlein
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 705a531 into main Sep 8, 2021
@roboquat roboquat deleted the jk/changelog branch September 8, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csweichel csweichel Awaiting requested review from csweichel

Assignees

@csweichel csweichel

Labels
approved size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JanKoehnlein @csweichel @roboquat