Enable Teams & Projects on joining of a team

[AlexTugarev]

Closes #5476

[jankeromnes]

Looks good to me! And does the job 👍 thanks @AlexTugarev.

Left two suggestions in-line. Please feel free to address or dismiss them. Then, please feel free to manually carry over the lgtm label, and to remove the hold (without re-requesting a review 🌴).

/approve
/lgtm
/hold

[jankeromnes]

You could simplify this Effect's 🍝 code a bit by adding if (!user) { return; } at the top. (Also the empty line is unnecessary. 😇)

[AlexTugarev]

I'd love to see that PR reverted rather soon, i.e. getting to general availability of Teams & Projects. I would be great to just revert this PR by then with less effort. WDYT?

[roboquat]

LGTM label has been added.

Git tree hash: db9b88b1308072ce3bbf5eeffa72612d48b35518

[gtsiolis]

Works as expected! Thanks for adding this @AlexTugarev! 🧙

For a UX perspective there's a small but barely noticeable change in the user interface when joining a team but this is probably a broader issue with the frontend app, right? See screen recording and notice the top menu changing two times and page error (undefined) before loading the team.

Untitled.mov

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes

Associated issue: #5476

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS [jankeromnes]
• components/server/OWNERS [jankeromnes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[AlexTugarev]

/hold cancel

[AlexTugarev]

wrt #5477 (review)

@gtsiolis, yes it seems to be related to the decoupled states of pages and menu. as we want the menu to render quickly, we cannot await the additional roundtrip.

[gtsiolis]

yes it seems to be related to the decoupled states of pages and menu. as we want the menu to render quickly, we cannot await the additional roundtrip.

Thanks for clarifying @AlexTugarev!