Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server, paymentendpoint] Fix config (parsing) #5482

Merged
merged 1 commit into from
Sep 1, 2021
Merged

[server, paymentendpoint] Fix config (parsing) #5482

merged 1 commit into from
Sep 1, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 1, 2021

Aftermath of #4982

@geropl geropl requested review from fullmetalrooster and removed request for AlexTugarev September 1, 2021 13:31
@fullmetalrooster
Copy link
Contributor

/lgtm

@geropl
Copy link
Member Author

geropl commented Sep 1, 2021

/approve no-issue

@roboquat roboquat added the lgtm label Sep 1, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

LGTM label has been added.

Git tree hash: a7d5a4fcb63bed9e5605c13574325d082de80a6e

@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, wulfthimm

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@roboquat
Copy link
Contributor

roboquat commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl, wulfthimm

Associated issue requirement bypassed by: geropl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geropl
Copy link
Member Author

geropl commented Sep 1, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-server-config-fix-i.2

@geropl
Copy link
Member Author

geropl commented Sep 1, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-server-config-fix-i.3

@roboquat roboquat merged commit 0b39fb8 into main Sep 1, 2021
@roboquat roboquat deleted the gpl/server-config-fix-i branch September 1, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fullmetalrooster fullmetalrooster Awaiting requested review from fullmetalrooster

Assignees

@fullmetalrooster fullmetalrooster

Labels
approved size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geropl @fullmetalrooster @roboquat