Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blobserve] Add error handling in MarkDone #5486

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

corneliusludmann
Copy link
Contributor

This change makes sure that when an error occurs in handleRequest(...) it will pass to Wait(...).

Fixes #5232

/cc @csweichel

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #5486 (61fcb3f) into main (6bc80eb) will increase coverage by 10.10%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5486       +/-   ##
===========================================
+ Coverage   19.39%   29.49%   +10.10%     
===========================================
  Files           2        3        +1     
  Lines         165      539      +374     
===========================================
+ Hits           32      159      +127     
- Misses        131      364      +233     
- Partials        2       16       +14     
Flag Coverage Δ
components-blobserve-app 29.49% <57.14%> (?)
components-local-app-app-linux ?
components-local-app-app-windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/blobserve/pkg/blobserve/refstore.go 64.82% <57.14%> (ø)
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go
components/blobserve/pkg/blobserve/blobspace.go 9.39% <0.00%> (ø)
components/blobserve/pkg/blobserve/blobserve.go 8.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc80eb...61fcb3f. Read the comment docs.

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

LGTM label has been added.

Git tree hash: 257e1f0ab75d5b65d68b84bb9304371f6c285ead

@roboquat
Copy link
Contributor

roboquat commented Sep 2, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5232

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 5c73a86 into main Sep 2, 2021
@roboquat roboquat deleted the clu/segfault-in-blobserve-5232 branch September 2, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in blobserve
3 participants