Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ws-manager-api] Remove hardcoded grpc call deadline #5510

Merged
merged 1 commit into from
Sep 6, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 2, 2021

Remove deadline now that we have reconnections and keepalive settings enabled

fixes #5414

@aledbf
Copy link
Member Author

aledbf commented Sep 2, 2021

/hold

@aledbf
Copy link
Member Author

aledbf commented Sep 2, 2021

/hold cancel
/assign @csweichel

@aledbf
Copy link
Member Author

aledbf commented Sep 2, 2021

/team workspace

@aledbf
Copy link
Member Author

aledbf commented Sep 2, 2021

/werft run

👍 started the job as gitpod-build-aledbf-tsgrpc.1

@csweichel
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Sep 6, 2021
@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

LGTM label has been added.

Git tree hash: 0b77645edae2b9616c6b59ab1dbcfc06162eb09e

@roboquat
Copy link
Contributor

roboquat commented Sep 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5414

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a8e41ec into main Sep 6, 2021
@roboquat roboquat deleted the aledbf/tsgrpc branch September 6, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEADLINE_EXCEEDED: gRPC communication trouble
3 participants