-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common-go] Do not log EOF errors decoding JSON #5696
Conversation
/assign @csweichel |
Codecov Report
@@ Coverage Diff @@
## main #5696 +/- ##
===========================================
+ Coverage 19.04% 32.67% +13.63%
===========================================
Files 2 104 +102
Lines 168 20334 +20166
===========================================
+ Hits 32 6645 +6613
- Misses 134 13111 +12977
- Partials 2 578 +576
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5c1789a
to
6f5efe8
Compare
/werft run 👍 started the job as gitpod-build-aledbf-eof.8 |
ea07653
to
e91ae75
Compare
054d056
to
5d23b6c
Compare
/lgtm |
/approve no-issue |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, csweichel Associated issue requirement bypassed by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
There is no check to the output generated by commands that emit JSON logs.
The PR checks we have a valid logrus entry in JSON format and verifies for conditions like empty content, end of lines, mixed content and invalid JSON.
Related Issue(s)
Internal link: https://cloudlogging.app.goo.gl/PS8PUnkJ7HZbMASS8
How to test
Release Notes
/approve no-issue