Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runc-facade] Remove unpriv port sysctl #5815

Merged
merged 3 commits into from
Sep 23, 2021
Merged

[runc-facade] Remove unpriv port sysctl #5815

merged 3 commits into from
Sep 23, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Sep 22, 2021 •
edited
Loading

Description

This change makes Docker 20.10 work in Gitpod.

Related Issue(s)

Fixes #3051

How to test

sudo apt-get update
sudo apt-get install docker-ce
docker run --rm -it -p 5000:5000 alpine:latest

Release Notes

[workspace] Support Docker 20.10

@csweichel
Copy link
Contributor Author

/hold

this seems to have broken port forwarding with 20.10

@csweichel
Copy link
Contributor Author

/hold cancel

@csweichel
Copy link
Contributor Author

/assign @aledbf

@roboquat roboquat added size/S and removed size/XS labels Sep 23, 2021
@aledbf
Copy link
Member

aledbf commented Sep 23, 2021

/lgtm
/approve

@roboquat roboquat added the lgtm label Sep 23, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: df103a6030ad5659eb75a915786189b3360496ae

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

Associated issue: #3051

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 2a8cf55 into main Sep 23, 2021
@roboquat roboquat deleted the cw/fix-3051 branch September 23, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsimonemms mrsimonemms Awaiting requested review from mrsimonemms

Assignees

@aledbf aledbf

Labels
approved release-note size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docker] Make Docker 20.10.2 work
3 participants
@csweichel @aledbf @roboquat