Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Fix log format so it can be parsed again #5899

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

geropl
Copy link
Member

@geropl geropl commented Sep 28, 2021

Description

Currently the log output looks like this:

{
    "component": "server",
    "serverity": "INFO",
    "time": ....
    "environment": "staging",
    "payload": [
      false,
      [
        "Request getHeadlessLog unsuccessful",
        {
          "args": [
            ....
          ],
          "method": "getHeadlessLog"
        }
      ]
    ],
    "component": "server",
    "region": "europe-west1",
    "loggedViaConsole": true
  }

where it should look likes this:

{
    "component": "server",
    "severity": "INFO",
    "time": "2021-09-28T08:55:39.089Z",
    "environment": "devstaging",
    "region": "europe-west1",
    "message": ...,
    "payload": {
        "id": "...",
        "domain": "",
        "level": 1,
        "validUntil": ...,
        "seats": 5
    },
    "loggedViaConsole": true
}

to be properly parsed by cloud console.

Related Issue(s)

Fixes #

How to test

Release Notes

fix log format for meta components

@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

@geropl geropl removed the request for review from JanKoehnlein September 28, 2021 09:03
@geropl geropl marked this pull request as ready for review September 28, 2021 09:03
@roboquat roboquat added size/M and removed size/S labels Sep 28, 2021
@AlexTugarev
Copy link
Member

AlexTugarev commented Sep 28, 2021

/werft run

👍 started the job as gitpod-build-gpl-fix-log-format.3

@AlexTugarev
Copy link
Member

/lgtm

thanks for fixing this!

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd00fcc3582cf2eb1da86a1b56e9e20f91f56c0a

@AlexTugarev
Copy link
Member

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue requirement bypassed by: AlexTugarev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 498535e into main Sep 28, 2021
@roboquat roboquat deleted the gpl/fix-log-format branch September 28, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants