Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5 second interval automatic page reload to default 404 page for unserved ports. #5938

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

rohan-patra
Copy link
Contributor

@rohan-patra rohan-patra commented Sep 29, 2021

Description

Add 5 second interval automatic page reload to default 404 page for unserved ports.

Why

Thought this was an easy addition of a beneficial feature, also saw it mentioned here: https://community.gitpod.io/t/auto-reload-of-port-not-available/5187

How to test

Try opening an unserved port from a running workspace and the page should automatically reload every 5 seconds until the port is served.

Release Notes

Add automatic five second page reload to the "port not found" page

default 404 page for unserved ports.
@princerachit
Copy link
Contributor

fixes: #5932

@csweichel
Copy link
Contributor

csweichel commented Sep 30, 2021

/werft run

👍 started the job as gitpod-build-main-fork.13

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #5938 (3fc3c14) into main (5a134c6) will increase coverage by 49.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #5938       +/-   ##
===========================================
+ Coverage   19.04%   68.89%   +49.84%     
===========================================
  Files           2        8        +6     
  Lines         168     1315     +1147     
===========================================
+ Hits           32      906      +874     
- Misses        134      349      +215     
- Partials        2       60       +58     
Flag Coverage Δ
components-local-app-app-linux ?
components-local-app-app-windows ?
components-ws-proxy-app 68.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-proxy/pkg/proxy/infoprovider.go 59.45% <0.00%> (ø)
components/ws-proxy/pkg/proxy/routes.go 83.64% <0.00%> (ø)
components/ws-proxy/pkg/proxy/workspacerouter.go 81.73% <0.00%> (ø)
components/ws-proxy/pkg/proxy/proxy.go 30.35% <0.00%> (ø)
components/ws-proxy/pkg/proxy/pass.go 74.40% <0.00%> (ø)
components/ws-proxy/pkg/proxy/cookies.go 78.57% <0.00%> (ø)
components/ws-proxy/pkg/proxy/config.go 0.00% <0.00%> (ø)
components/ws-proxy/pkg/proxy/auth.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a134c6...3fc3c14. Read the comment docs.

@csweichel
Copy link
Contributor

works as expected. Thank you for the fix.

/lgtm
/approve no-issue

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 963177b5997e9de4aa2bc64884d0932e6cb737a2

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue requirement bypassed by: csweichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 7e34c6c into gitpod-io:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants