-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support per-workspace filesystem quota on /workspace
#5982
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5982 +/- ##
==========================================
+ Coverage 19.04% 22.13% +3.09%
==========================================
Files 2 13 +11
Lines 168 2141 +1973
==========================================
+ Hits 32 474 +442
- Misses 134 1606 +1472
- Partials 2 61 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/hold until it's clear if we need to remove the nodepool commit (which we need for testing) |
/werft run 👍 started the job as gitpod-build-cw-fix-a-4938.15 |
Works as advertised. I fill the disk using /lgtm |
LGTM label has been added. Git tree hash: 4cd92f9ce637a067d02f63f2968051e50e42f04f
|
Also checked the project is removed when the workspace is stopped from ws-daemon when /workspace is full
after deleting the file
|
@wulfthimm what would be the consequence if we merged this PR with the nodepool change? |
In my first PR which introduced |
fff2e9d
to
8cd2f40
Compare
/hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: 55ace7f7294ff6c9122772eb602387a89130ca4e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf Associated issue: #4938 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR implements XFS based filesystem quota for each workspace in their resp.
/workspace
directory.Related Issue(s)
Fixes #4938
How to test
df -h
and you should see a limit of50gb
on/workspace
Release Notes
Caveats
nodepool 4
commit. @wulfthimm can you confirm?prjquota
. In core-dev this means we need to deploy this ws-daemon first on a nodepool so that theraid-local-disks
container can mount the XFS filesystem withprjquota