[image-builder-mk3] Fix image build error "did not produce a workspace image"

[aledbf]

Description

The generated workspace ID by the computeBuildID helper could produce collisions

Related Issue(s)

Fixes #5981

How to test

Release Notes

[image-builder-mk3] Fix image build error "did not produce a workspace image"

[aledbf]

/assign @csweichel

[aledbf]

I see some warnings

{"@type":"type.googleapis.com/google.devtools.clouderrorreporting.v1beta1.ReportedErrorEvent","buildID":"03bd1619-05ce-4396-9228-b64dcc941546","error":"out of retries:\n    github.com/gitpod-io/gitpod/image-builder/pkg/orchestrator.init\n        github.com/gitpod-io/gitpod/image-builder/pkg/orchestrator/monitor.go:164","level":"warning","message":"headless log listener failed","serviceContext":{"service":"image-builder-mk3","version":""},"severity":"WARNING","time":"2021-10-07T01:12:34Z"}

(but no build errors running the integration tests related to images)

[codecov]

Codecov Report

Merging #6090 (a94ad43) into main (3692b2f) will increase coverage by 25.24%.
The diff coverage is 13.88%.

@@            Coverage Diff             @@
##            main    #6090       +/-   ##
==========================================
+ Coverage   8.21%   33.46%   +25.24%     
==========================================
  Files         12       27       +15     
  Lines       1022     5636     +4614     
==========================================
+ Hits          84     1886     +1802     
- Misses       934     3587     +2653     
- Partials       4      163      +159     

Flag	Coverage Δ
components-image-builder-app	34.44% <ø> (?)
components-image-builder-mk3-app	34.76% <45.45%> (?)
components-local-app-app-linux-amd64	?
components-local-app-app-linux-arm64	?
components-local-app-app-windows-386	?
components-local-app-app-windows-amd64	?
components-local-app-app-windows-arm64	?
components-ws-manager-app	39.28% <0.00%> (?)
installer-app	6.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/ws-manager/pkg/manager/manager.go	25.13% <0.00%> (ø)
...image-builder-mk3/pkg/orchestrator/orchestrator.go	39.16% <33.33%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/monitor.go	24.90% <100.00%> (ø)
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
components/ws-manager/pkg/manager/metrics.go	11.11% <0.00%> (ø)
components/ws-manager/pkg/manager/annotations.go	65.11% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/metrics.go	48.14% <0.00%> (ø)
...s/ws-manager/pkg/manager/internal/grpcpool/pool.go	71.83% <0.00%> (ø)
components/image-builder/pkg/resolve/resolve.go	34.26% <0.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3692b2f...a94ad43. Read the comment docs.

[aledbf]

/hold

[csweichel]

I'd expect this to break the "concurrent build detection" mechanism. I.e. if two requests that resolve to the same wsrefstr come in now, they'd both build the image in parallel rather than one listening to the other.

[csweichel]

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 0bd5d9066ea3e880b6267b5b997bf64e0ad8d69a

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #5981

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csweichel]
• components/image-builder-api/OWNERS [csweichel]
• components/ws-manager/OWNERS [csweichel]
• dev/gpctl/OWNERS [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment