Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] In /workspaces, indicate when you have active workspaces in your teams #6103

Merged
merged 2 commits into from
Oct 7, 2021
Merged

[dashboard] In /workspaces, indicate when you have active workspaces in your teams #6103

merged 2 commits into from
Oct 7, 2021

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Oct 7, 2021 •
edited
Loading

Description

Related Issue(s)

Fixes #6098

How to test

  1. Create a Team with a Project (but don't create workspaces yet)
  2. Go to /workspaces -- it should be empty (no special message)
  3. Now, start a workspace for that Team Project you created in 1.
  4. Go to /workspaces again -- there should now be a message about the active workspace under your team

Release Notes

[dashboard] In /workspaces, indicate when you have active workspaces in your teams

/uncc

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

please ask for approval from jankeromnes

I do approve of my own PR 🤦

/approve

@jankeromnes jankeromnes force-pushed the jx/team-workspaces-shortcut branch 2 times, most recently from 274847c to a673443 Compare October 7, 2021 13:18
@jankeromnes jankeromnes mentioned this pull request Oct 7, 2021
Closed
@roboquat roboquat added size/M and removed size/S labels Oct 7, 2021
@jankeromnes jankeromnes force-pushed the jx/team-workspaces-shortcut branch 2 times, most recently from da4c0f6 to c22a313 Compare October 7, 2021 15:27
@jankeromnes jankeromnes marked this pull request as ready for review October 7, 2021 15:41
@jankeromnes
Copy link
Contributor Author

Current state: I've implemented the specs as in #6098 (comment)

Spec This PR
Screenshot 2021-10-07 at 4 32 53 PM (2) Screenshot 2021-10-07 at 17 40 48
Screenshot 2021-10-07 at 4 28 58 PM (2) Screenshot 2021-10-07 at 17 40 20
Screenshot 2021-10-07 at 4 26 46 PM (2) Screenshot 2021-10-07 at 17 38 46
Screenshot 2021-10-07 at 4 25 41 PM (2) Screenshot 2021-10-07 at 17 37 42

But I'm happy to try with a grey background as in #6098 (comment) -- what do you think @gtsiolis?

@gtsiolis
Copy link
Contributor

gtsiolis commented Oct 7, 2021 •
edited
Loading

Woohoo! Thanks @jankeromnes! Tried this a bit and I think a) using the gray background feels more balanced and b) using top placement like an anchor always at the top feels right as it always groups relevant information that is active workspaces. Also, using the top placement follows the same pattern where the link for other team is always at the top.

@jankeromnes jankeromnes force-pushed the jx/team-workspaces-shortcut branch 2 times, most recently from 41ff9e3 to 14ea0b6 Compare October 7, 2021 16:12
@jankeromnes jankeromnes force-pushed the jx/team-workspaces-shortcut branch 2 times, most recently from 58b94ed to 6f44e36 Compare October 7, 2021 16:36
@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Deal! 🤝

Spec Current state of this PR
Screenshot 2021-10-07 at 6 24 46 PM (2) Screenshot 2021-10-07 at 18 43 28
Screenshot 2021-10-07 at 6 32 31 PM (2) Screenshot 2021-10-07 at 18 42 34
Screenshot 2021-10-07 at 6 26 27 PM (2) Screenshot 2021-10-07 at 18 41 34

I've also removed the bogus hover state on the garbage-collection message. 😁 🙌

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

@gtsiolis Please confirm that the UX works as expected 🙏

@AlexTugarev Please confirm that the code looks good 🙏

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Tried to sneak in a one-line speed-up, but Werft wasn't happy about that. 😅

/werft run

👍 started the job as gitpod-build-jx-team-workspaces-shortcut.13

gtsiolis
gtsiolis approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX Ready-To-Ship. 🚢

Thanks for adding this @jankeromnes!

Approving to unblock merging but holding in case this needs a closer look at the code changes.

/hold

@roboquat roboquat added the lgtm label Oct 7, 2021
@roboquat
Copy link
Contributor

roboquat commented Oct 7, 2021

LGTM label has been added.

Git tree hash: 04de4fcbaeee75b9f28b4a3e5f89409de55adddf

@roboquat
Copy link
Contributor

roboquat commented Oct 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gtsiolis, jankeromnes

Associated issue: #6098

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jankeromnes
Copy link
Contributor Author

jankeromnes commented Oct 7, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Thanks again for the phenomenal designs and A+ code reviews! 😁 🙏

After another look, I think the code changes are actually fine and quite minimal. 😊 Let's merge this and deploy it tomorrow morning! 🚢 🚀 💥

/hold cancel

@jankeromnes jankeromnes removed the request for review from AlexTugarev October 7, 2021 19:07
@roboquat roboquat merged commit fe991b8 into main Oct 7, 2021
@roboquat roboquat deleted the jx/team-workspaces-shortcut branch October 7, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

Labels
approved release-note size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX] Add direct link to active workspaces in other teams
3 participants
@jankeromnes @gtsiolis @roboquat