Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projects] fix project association for workspaces based on prebuilds #6117

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Oct 8, 2021

Description

A follow-up to #6097

Related Issue(s)

Fixes #6116

How to test

  1. create a team and a project with prebuilds configured.
  2. create a prebuild
  3. with another account (not a member of the same team) try to start a workspace for the repo from 1.)
  4. see that the workspace is shown in the personal space (/workspaces)

Release Notes

[Dashboard] Fix workspace-project associations for workspaces based on prebuilds.

Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the quick fix! 🎉

Code change looks good and works like a charm. ❇️

@roboquat
Copy link
Contributor

roboquat commented Oct 8, 2021

LGTM label has been added.

Git tree hash: fe72a611f630409e317e935a91b77a109473a900

@roboquat
Copy link
Contributor

roboquat commented Oct 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

Associated issue: #6116

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 3bace2d into main Oct 8, 2021
@roboquat roboquat deleted the at/fix-project-association branch October 8, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[projects] Fix workspace/project association when based on a prebuild
3 participants