Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code] update stable to 1.61.0 #6149

Merged
merged 1 commit into from
Oct 12, 2021
Merged

[code] update stable to 1.61.0 #6149

merged 1 commit into from
Oct 12, 2021

Conversation

akosyakov
Copy link
Member

Description

Aligns stable VS Code Web with insiders.

Related Issue(s)

Fixes #

How to test

  • Start a workspace.
  • Use about dialog to check that version is 1.61.0.
  • Smoke test a bit.

Release Notes

Update VS Code Web to 1.61.0

Documentation

@akosyakov akosyakov requested review from corneliusludmann and removed request for jankeromnes October 11, 2021 12:42
@akosyakov
Copy link
Member Author

It works but for some reason workspace instance events does not arrive. I don't think it is related to PR change though.

@jeanp413
Copy link
Member

@akosyakov It doesn't load in my case, it's just stuck in checking, should I trigger a werft rebuild?
image

@akosyakov
Copy link
Member Author

Try to reload, page reload worked for me. But something weird with prev enge

@jeanp413
Copy link
Member

jeanp413 commented Oct 12, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-ak-udpate-code-1.61.0.2

jeanp413
jeanp413 approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@jeanp413 jeanp413 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akosyakov LGTM, only issue is the stuck state when opening a new workspace and needs a reload but as you mentioned that's unrelated to the update

@roboquat roboquat added the lgtm label Oct 12, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c4e801b406f997b7952c352f325e6434b686c5d

@akosyakov
Copy link
Member Author

/approve no-issue

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, jeanp413

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 01d1093 into main Oct 12, 2021
@roboquat roboquat deleted the ak/udpate_code_1.61.0 branch October 12, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 jeanp413 approved these changes

@corneliusludmann corneliusludmann Awaiting requested review from corneliusludmann

Assignees

@jeanp413 jeanp413

Labels
approved release-note size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akosyakov @jeanp413 @roboquat